Source/modules/geolocation/GeolocationController.h - Issue 490143002: Move GeolocationClient to the Oilpan heap.

Side by Side Diff: Source/modules/geolocation/GeolocationController.h

Issue 490143002: Move GeolocationClient to the Oilpan heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Provide default empty impl of WebGeolocationClient::geolocationDestroyed() virtual Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 2009 Apple Inc. All rights reserved.	2 * Copyright (C) 2009 Apple Inc. All rights reserved.

3 *	3 *

4 * Redistribution and use in source and binary forms, with or without	4 * Redistribution and use in source and binary forms, with or without

5 * modification, are permitted provided that the following conditions	5 * modification, are permitted provided that the following conditions

6 * are met:	6 * are met:

7 * 1. Redistributions of source code must retain the above copyright	7 * 1. Redistributions of source code must retain the above copyright

8 * notice, this list of conditions and the following disclaimer.	8 * notice, this list of conditions and the following disclaimer.

9 * 2. Redistributions in binary form must reproduce the above copyright	9 * 2. Redistributions in binary form must reproduce the above copyright

10 * notice, this list of conditions and the following disclaimer in the	10 * notice, this list of conditions and the following disclaimer in the

(...skipping 53 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
64 GeolocationClient* client() { return m_client; }	64 GeolocationClient* client() { return m_client; }

65	65

66 // Inherited from PageLifecycleObserver.	66 // Inherited from PageLifecycleObserver.

67 virtual void pageVisibilityChanged() OVERRIDE;	67 virtual void pageVisibilityChanged() OVERRIDE;

68	68

69 static const char* supplementName();	69 static const char* supplementName();

70 static GeolocationController* from(LocalFrame* frame) { return static_cast<G eolocationController*>(WillBeHeapSupplement<LocalFrame>::from(frame, supplementN ame())); }	70 static GeolocationController* from(LocalFrame* frame) { return static_cast<G eolocationController*>(WillBeHeapSupplement<LocalFrame>::from(frame, supplementN ame())); }

71	71

72 // Inherited from Supplement.	72 // Inherited from Supplement.

73 virtual void trace(Visitor*) OVERRIDE;	73 virtual void trace(Visitor*) OVERRIDE;

74 virtual void willBeDestroyed() OVERRIDE;

75 virtual void persistentHostHasBeenDestroyed() OVERRIDE;	74 virtual void persistentHostHasBeenDestroyed() OVERRIDE;

76	75

77 private:	76 private:

78 GeolocationController(LocalFrame&, GeolocationClient*);	77 GeolocationController(LocalFrame&, GeolocationClient*);

79	78

80 void startUpdatingIfNeeded();	79 void startUpdatingIfNeeded();

81 void stopUpdatingIfNeeded();	80 void stopUpdatingIfNeeded();

82	81

83 void detach();	82 RawPtrWillBeMember<GeolocationClient> m_client;

84

85 GeolocationClient* m_client;

86 bool m_hasClientForTest;	83 bool m_hasClientForTest;

87	84

88 PersistentWillBeMember<GeolocationPosition> m_lastPosition;	85 PersistentWillBeMember<GeolocationPosition> m_lastPosition;

89 typedef PersistentHeapHashSetWillBeHeapHashSet<Member<Geolocation> > Observe rsSet;	86 typedef PersistentHeapHashSetWillBeHeapHashSet<Member<Geolocation> > Observe rsSet;

90 // All observers; both those requesting high accuracy and those not.	87 // All observers; both those requesting high accuracy and those not.

91 ObserversSet m_observers;	88 ObserversSet m_observers;

92 ObserversSet m_highAccuracyObservers;	89 ObserversSet m_highAccuracyObservers;

93 bool m_isClientUpdating;	90 bool m_isClientUpdating;

94 RawPtrWillBeMember<GeolocationInspectorAgent> m_inspectorAgent;	91 RawPtrWillBeMember<GeolocationInspectorAgent> m_inspectorAgent;

95 };	92 };

96	93

97 } // namespace blink	94 } // namespace blink

98	95

99 #endif // GeolocationController_h	96 #endif // GeolocationController_h

OLD	NEW