Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Unified Diff: Source/modules/geolocation/GeolocationClient.h

Issue 490143002: Move GeolocationClient to the Oilpan heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Provide default empty impl of WebGeolocationClient::geolocationDestroyed() virtual Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/modules/geolocation/GeolocationClient.h
diff --git a/Source/modules/geolocation/GeolocationClient.h b/Source/modules/geolocation/GeolocationClient.h
index 9b51f367e7034bb46b2880ac05ae52b5d55effcf..609b75e691cd9c380bd95e26c057017cf3a3685e 100644
--- a/Source/modules/geolocation/GeolocationClient.h
+++ b/Source/modules/geolocation/GeolocationClient.h
@@ -26,6 +26,8 @@
#ifndef GeolocationClient_h
#define GeolocationClient_h
+#include "platform/heap/Handle.h"
+
namespace blink {
class Geolocation;
@@ -33,9 +35,9 @@ class GeolocationController;
class GeolocationPosition;
class LocalFrame;
-class GeolocationClient {
+class GeolocationClient : public NoBaseWillBeGarbageCollectedFinalized<GeolocationClient> {
public:
- virtual void geolocationDestroyed() = 0;
+ virtual ~GeolocationClient() { }
virtual void startUpdating() = 0;
virtual void stopUpdating() = 0;
@@ -48,8 +50,7 @@ public:
virtual void controllerForTestAdded(GeolocationController*) { }
virtual void controllerForTestRemoved(GeolocationController*) { }
-protected:
- virtual ~GeolocationClient() { }
+ virtual void trace(Visitor*) { }
};
void provideGeolocationTo(LocalFrame&, GeolocationClient*);

Powered by Google App Engine
This is Rietveld 408576698