Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(353)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 489313002: Centralize command line checks for kEnableStreamlinedHostedApps. (Closed)

Created:
6 years, 4 months ago by benwells
Modified:
6 years, 3 months ago
Reviewers:
calamity, sky
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, extensions-reviews_chromium.org, sadrul, estade+watch_chromium.org, tfarina, dbeam+watch-ntp_chromium.org, kalyank, chromium-apps-reviews_chromium.org, ben+ash_chromium.org, pedrosimonetti+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Centralize command line checks for kEnableStreamlinedHostedApps. This moves all checks in the browser process into a common function. BUG=368372 Committed: https://crrev.com/39f23aea6a999e6f80ba301652bfce1a3e950018 Cr-Commit-Position: refs/heads/master@{#292118}

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Use in another spot #

Patch Set 4 : Rebase #

Patch Set 5 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -73 lines) Patch
M chrome/browser/extensions/api/management/management_api.cc View 1 2 3 4 3 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/extensions/extension_util.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/extensions/extension_util.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/extensions/launch_util.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M chrome/browser/extensions/tab_helper.cc View 1 2 3 4 chunks +2 lines, -4 lines 0 comments Download
M chrome/browser/ui/app_list/app_context_menu.cc View 1 2 3 4 3 chunks +3 lines, -6 lines 0 comments Download
M chrome/browser/ui/app_list/extension_app_item.cc View 3 chunks +2 lines, -4 lines 0 comments Download
M chrome/browser/ui/app_list/extension_app_model_builder.cc View 1 2 3 4 3 chunks +2 lines, -4 lines 0 comments Download
M chrome/browser/ui/ash/launcher/launcher_app_tab_helper.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M chrome/browser/ui/ash/launcher/launcher_context_menu.cc View 1 2 3 4 3 chunks +3 lines, -6 lines 0 comments Download
M chrome/browser/ui/browser.cc View 1 2 3 4 3 chunks +4 lines, -6 lines 0 comments Download
M chrome/browser/ui/browser_command_controller.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/startup/startup_browser_creator_impl.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/toolbar/wrench_menu_model.cc View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/apps/app_info_dialog/app_info_summary_panel.cc View 1 2 3 4 2 chunks +2 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.cc View 3 chunks +2 lines, -5 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_view.cc View 1 2 3 4 3 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/location_bar/location_bar_view.cc View 1 2 3 4 4 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/toolbar/toolbar_view.cc View 1 2 3 4 4 chunks +4 lines, -7 lines 0 comments Download
M chrome/browser/ui/webui/ntp/ntp_resource_cache.cc View 1 2 3 4 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 29 (0 generated)
benwells
6 years, 4 months ago (2014-08-21 05:50:09 UTC) #1
calamity
Much nicer! LGTM.
6 years, 4 months ago (2014-08-21 06:53:09 UTC) #2
benwells
sky for owners. It's a fairly mechanical change....
6 years, 4 months ago (2014-08-21 06:54:55 UTC) #3
sky
LGTM
6 years, 4 months ago (2014-08-21 16:43:06 UTC) #4
benwells
The CQ bit was checked by benwells@chromium.org
6 years, 4 months ago (2014-08-22 05:00:39 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/benwells@chromium.org/489313002/40001
6 years, 4 months ago (2014-08-22 05:01:41 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_tests_recipe on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-22 08:33:38 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-22 09:20:14 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_tests_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tests_recipe/builds/1361)
6 years, 4 months ago (2014-08-22 09:20:15 UTC) #9
benwells
The CQ bit was checked by benwells@chromium.org
6 years, 4 months ago (2014-08-25 22:47:05 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/benwells@chromium.org/489313002/40001
6 years, 4 months ago (2014-08-25 22:48:51 UTC) #11
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_tests_recipe on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-26 00:00:54 UTC) #12
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-26 01:04:44 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_tests_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tests_recipe/builds/2139)
6 years, 4 months ago (2014-08-26 01:04:46 UTC) #14
benwells
The CQ bit was checked by benwells@chromium.org
6 years, 4 months ago (2014-08-26 05:20:53 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/benwells@chromium.org/489313002/60001
6 years, 4 months ago (2014-08-26 05:21:22 UTC) #16
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_gpu on tryserver.chromium.gpu ...
6 years, 4 months ago (2014-08-26 05:31:40 UTC) #17
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-26 05:34:15 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: mac_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/46218) ios_dbg_simulator on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator/builds/8945) ios_rel_device ...
6 years, 4 months ago (2014-08-26 05:34:16 UTC) #19
benwells
The CQ bit was checked by benwells@chromium.org
6 years, 3 months ago (2014-08-27 03:31:25 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/benwells@chromium.org/489313002/60001
6 years, 3 months ago (2014-08-27 03:32:03 UTC) #21
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_gpu on tryserver.chromium.gpu ...
6 years, 3 months ago (2014-08-27 03:43:08 UTC) #22
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 3 months ago (2014-08-27 03:44:36 UTC) #23
commit-bot: I haz the power
Try jobs failed on following builders: mac_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/46773) ios_dbg_simulator on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator/builds/9375) ios_rel_device_ninja ...
6 years, 3 months ago (2014-08-27 03:44:37 UTC) #24
benwells
The CQ bit was checked by benwells@chromium.org
6 years, 3 months ago (2014-08-27 06:31:42 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/benwells@chromium.org/489313002/80001
6 years, 3 months ago (2014-08-27 06:32:29 UTC) #26
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_gpu_triggered_tests on tryserver.chromium.gpu ...
6 years, 3 months ago (2014-08-27 07:26:59 UTC) #27
commit-bot: I haz the power
Committed patchset #5 (80001) as 96734d3e23cefbe02a4bc933630f4d0fc82f13ec
6 years, 3 months ago (2014-08-27 08:02:10 UTC) #28
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:50:29 UTC) #29
Message was sent while issue was closed. 
Patchset 5 (id:??) landed as
https://crrev.com/39f23aea6a999e6f80ba301652bfce1a3e950018
Cr-Commit-Position: refs/heads/master@{#292118}

Powered by Google App Engine
This is Rietveld 408576698