chrome/browser/ui/views/apps/app_info_dialog/app_info_summary_panel.cc - Issue 489313002: Centralize command line checks for kEnableStreamlinedHostedApps.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/apps/app_info_dialog/app_info_summary_panel.cc

Issue 489313002: Centralize command line checks for kEnableStreamlinedHostedApps. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebase Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/toolbar/wrench_menu_model.cc ('k') | chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/apps/app_info_dialog/app_info_summary_panel.cc

diff --git a/chrome/browser/ui/views/apps/app_info_dialog/app_info_summary_panel.cc b/chrome/browser/ui/views/apps/app_info_dialog/app_info_summary_panel.cc

index e289d751729440581570e1f156d919360af21bb5..99f48583df0f72acc056accbaf9b0e25a25a8200 100644

--- a/chrome/browser/ui/views/apps/app_info_dialog/app_info_summary_panel.cc

+++ b/chrome/browser/ui/views/apps/app_info_dialog/app_info_summary_panel.cc

@@ -7,16 +7,15 @@

#include <vector>

#include "base/callback_forward.h"

-#include "base/command_line.h"

#include "base/files/file_util.h"

#include "base/i18n/time_formatting.h"

#include "base/logging.h"

#include "base/strings/utf_string_conversions.h"

#include "base/task_runner_util.h"

#include "chrome/browser/extensions/extension_service.h"

+#include "chrome/browser/extensions/extension_util.h"

#include "chrome/browser/extensions/launch_util.h"

#include "chrome/browser/profiles/profile.h"

-#include "chrome/common/chrome_switches.h"

#include "chrome/common/extensions/extension_constants.h"

#include "chrome/grit/generated_resources.h"

#include "content/public/browser/browser_thread.h"

@@ -58,8 +57,7 @@ class LaunchOptionsComboboxModel : public ui::ComboboxModel {

};

LaunchOptionsComboboxModel::LaunchOptionsComboboxModel() {

- if (CommandLine::ForCurrentProcess()->HasSwitch(

- switches::kEnableStreamlinedHostedApps)) {

+ if (extensions::util::IsStreamlinedHostedAppsEnabled()) {

// Streamlined hosted apps can only toggle between LAUNCH_TYPE_WINDOW and

// LAUNCH_TYPE_REGULAR.

// TODO(sashab): Use a checkbox for this choice instead of combobox.