chrome/browser/ui/app_list/extension_app_model_builder.cc - Issue 489313002: Centralize command line checks for kEnableStreamlinedHostedApps.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/app_list/extension_app_model_builder.cc

Issue 489313002: Centralize command line checks for kEnableStreamlinedHostedApps. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebase Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/app_list/extension_app_model_builder.cc

diff --git a/chrome/browser/ui/app_list/extension_app_model_builder.cc b/chrome/browser/ui/app_list/extension_app_model_builder.cc

index 6a391527f6c541444080bc9923a7b50d330057d8..24a8eaa32b577cab6be54cc5ad6c6ea24c0b0242 100644

--- a/chrome/browser/ui/app_list/extension_app_model_builder.cc

+++ b/chrome/browser/ui/app_list/extension_app_model_builder.cc

@@ -9,8 +9,8 @@

#include "base/auto_reset.h"

#include "base/bind.h"

#include "base/callback.h"

-#include "base/command_line.h"

#include "chrome/browser/extensions/extension_ui_util.h"

+#include "chrome/browser/extensions/extension_util.h"

#include "chrome/browser/extensions/install_tracker.h"

#include "chrome/browser/extensions/install_tracker_factory.h"

#include "chrome/browser/profiles/profile.h"

@@ -18,7 +18,6 @@

#include "chrome/browser/ui/app_list/app_list_syncable_service.h"

#include "chrome/browser/ui/app_list/app_list_syncable_service_factory.h"

#include "chrome/browser/ui/app_list/extension_app_item.h"

-#include "chrome/common/chrome_switches.h"

#include "chrome/common/pref_names.h"

#include "extensions/browser/extension_prefs.h"

#include "extensions/browser/extension_registry.h"

@@ -81,8 +80,7 @@ void ExtensionAppModelBuilder::InitializePrefChangeRegistrars() {

base::Bind(&ExtensionAppModelBuilder::OnProfilePreferenceChanged,

base::Unretained(this)));

- if (!CommandLine::ForCurrentProcess()->HasSwitch(

- switches::kEnableStreamlinedHostedApps))

+ if (!extensions::util::IsStreamlinedHostedAppsEnabled())

return;

// TODO(calamity): analyze the performance impact of doing this every