Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(446)

Issue 488133003: Second batch of corrections for incorrect paths. (Closed)

Created:
6 years, 4 months ago by jpmedley
Modified:
6 years, 4 months ago
Reviewers:
binji1, JF, binji
CC:
chromium-reviews, binji+watch_chromium.org, native-client-reviews_googlegroups.com, Sam Clegg
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Second batch of corrections for incorrect paths. BUG=none R= binji@chromium.org, jfb@chromium.org TEST=none NOTRY=true (documentation only change) Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291006

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix more paths. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+147 lines, -127 lines) Patch
M native_client_sdk/doc_generated/community/index.html View 1 chunk +1 line, -1 line 0 comments Download
M native_client_sdk/doc_generated/devguide/coding/3D-graphics.html View 2 chunks +3 lines, -3 lines 0 comments Download
M native_client_sdk/doc_generated/devguide/coding/native-client-modules.html View 1 chunk +3 lines, -3 lines 0 comments Download
M native_client_sdk/doc_generated/devguide/coding/progress-events.html View 1 chunk +2 lines, -2 lines 0 comments Download
M native_client_sdk/doc_generated/devguide/coding/view-focus-input-events.html View 1 chunk +6 lines, -6 lines 0 comments Download
M native_client_sdk/doc_generated/devguide/devcycle/debugging.html View 1 14 chunks +49 lines, -48 lines 0 comments Download
M native_client_sdk/doc_generated/devguide/devcycle/dynamic-loading.html View 1 chunk +7 lines, -1 line 0 comments Download
M native_client_sdk/src/doc/devguide/coding/3D-graphics.rst View 2 chunks +3 lines, -3 lines 0 comments Download
M native_client_sdk/src/doc/devguide/coding/native-client-modules.rst View 1 chunk +3 lines, -3 lines 0 comments Download
M native_client_sdk/src/doc/devguide/coding/progress-events.rst View 1 chunk +2 lines, -2 lines 0 comments Download
M native_client_sdk/src/doc/devguide/coding/view-focus-input-events.rst View 1 chunk +6 lines, -6 lines 0 comments Download
M native_client_sdk/src/doc/devguide/devcycle/debugging.rst View 1 14 chunks +54 lines, -48 lines 0 comments Download
M native_client_sdk/src/doc/devguide/devcycle/dynamic-loading.rst View 2 chunks +8 lines, -1 line 0 comments Download

Messages

Total messages: 12 (0 generated)
jpmedley
6 years, 4 months ago (2014-08-20 15:19:49 UTC) #1
binji
lgtm, w/ comment about NACL_SDK_ROOT https://codereview.chromium.org/488133003/diff/1/native_client_sdk/src/doc/devguide/devcycle/debugging.rst File native_client_sdk/src/doc/devguide/devcycle/debugging.rst (right): https://codereview.chromium.org/488133003/diff/1/native_client_sdk/src/doc/devguide/devcycle/debugging.rst#newcode427 native_client_sdk/src/doc/devguide/devcycle/debugging.rst:427: cd <NACL_SDK_ROOT>/pepper_<version>/examples/demo/drive same as ...
6 years, 4 months ago (2014-08-20 19:09:34 UTC) #2
jpmedley
I changed the paths further in this and the other change list. https://codereview.chromium.org/488133003/diff/1/native_client_sdk/src/doc/devguide/devcycle/debugging.rst File native_client_sdk/src/doc/devguide/devcycle/debugging.rst ...
6 years, 4 months ago (2014-08-20 20:15:02 UTC) #3
binji
better, thanks!
6 years, 4 months ago (2014-08-20 21:10:11 UTC) #4
jpmedley
The CQ bit was checked by jmedley@chromium.org
6 years, 4 months ago (2014-08-21 01:52:46 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jmedley@chromium.org/488133003/20001
6 years, 4 months ago (2014-08-21 01:53:38 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_gpu on tryserver.chromium.gpu ...
6 years, 4 months ago (2014-08-21 02:53:39 UTC) #7
JF
The CQ bit was unchecked by jfb@chromium.org
6 years, 4 months ago (2014-08-21 03:12:06 UTC) #8
JF
The CQ bit was checked by jfb@chromium.org
6 years, 4 months ago (2014-08-21 03:12:12 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jmedley@chromium.org/488133003/20001
6 years, 4 months ago (2014-08-21 03:13:13 UTC) #10
JF
On 2014/08/21 03:12:06, JF wrote: > The CQ bit was unchecked by mailto:jfb@chromium.org FYI I ...
6 years, 4 months ago (2014-08-21 03:14:10 UTC) #11
commit-bot: I haz the power
6 years, 4 months ago (2014-08-21 04:49:50 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (20001) as 291006

Powered by Google App Engine
This is Rietveld 408576698