Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issue 487723002: [turbofan] Add proper conversion operators for int32<->int64. (Closed)

Created:
6 years, 4 months ago by Benedikt Meurer
Modified:
6 years, 4 months ago
Reviewers:
Jarin
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

[turbofan] Add proper conversion operators for int32<->int64. This affects arm64 and x64. Note that we do not yet optimize these conversions. Later we will add support for merging these conversion operators into other operations during instruction selection. TEST=cctest,compiler-unittests R=jarin@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=23184

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+324 lines, -87 lines) Patch
M src/compiler/arm64/code-generator-arm64.cc View 2 chunks +6 lines, -8 lines 0 comments Download
M src/compiler/arm64/instruction-codes-arm64.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/compiler/arm64/instruction-selector-arm64.cc View 3 chunks +18 lines, -18 lines 0 comments Download
M src/compiler/change-lowering.cc View 3 chunks +5 lines, -3 lines 0 comments Download
M src/compiler/instruction-selector.cc View 3 chunks +13 lines, -6 lines 0 comments Download
M src/compiler/machine-node-factory.h View 3 chunks +12 lines, -8 lines 0 comments Download
M src/compiler/machine-operator.h View 1 chunk +7 lines, -4 lines 0 comments Download
M src/compiler/opcodes.h View 1 chunk +3 lines, -2 lines 0 comments Download
M src/compiler/operator-properties-inl.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/compiler/simplified-lowering.cc View 1 chunk +6 lines, -3 lines 2 comments Download
M src/compiler/x64/code-generator-x64.cc View 2 chunks +18 lines, -6 lines 0 comments Download
M src/compiler/x64/instruction-codes-x64.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/compiler/x64/instruction-selector-x64.cc View 2 chunks +18 lines, -16 lines 0 comments Download
M test/cctest/compiler/test-run-machops.cc View 1 chunk +43 lines, -0 lines 0 comments Download
M test/compiler-unittests/arm64/instruction-selector-arm64-unittest.cc View 2 chunks +31 lines, -2 lines 0 comments Download
M test/compiler-unittests/change-lowering-unittest.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M test/compiler-unittests/compiler-unittests.h View 1 chunk +5 lines, -0 lines 0 comments Download
M test/compiler-unittests/compiler-unittests.gyp View 2 chunks +6 lines, -0 lines 0 comments Download
M test/compiler-unittests/graph-unittest.h View 1 chunk +3 lines, -1 line 0 comments Download
M test/compiler-unittests/graph-unittest.cc View 1 chunk +3 lines, -1 line 0 comments Download
A test/compiler-unittests/machine-operator-unittest.cc View 1 chunk +75 lines, -0 lines 0 comments Download
A test/compiler-unittests/x64/instruction-selector-x64-unittest.cc View 1 chunk +43 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Benedikt Meurer
6 years, 4 months ago (2014-08-19 08:21:00 UTC) #1
Jarin
lgtm https://codereview.chromium.org/487723002/diff/1/src/compiler/simplified-lowering.cc File src/compiler/simplified-lowering.cc (right): https://codereview.chromium.org/487723002/diff/1/src/compiler/simplified-lowering.cc#newcode632 src/compiler/simplified-lowering.cc:632: kTypeInt64 | kRepWord64); Why did you change the ...
6 years, 4 months ago (2014-08-19 08:46:36 UTC) #2
Benedikt Meurer
https://codereview.chromium.org/487723002/diff/1/src/compiler/simplified-lowering.cc File src/compiler/simplified-lowering.cc (right): https://codereview.chromium.org/487723002/diff/1/src/compiler/simplified-lowering.cc#newcode632 src/compiler/simplified-lowering.cc:632: kTypeInt64 | kRepWord64); On 2014/08/19 08:46:36, jarin wrote: > ...
6 years, 4 months ago (2014-08-19 08:48:07 UTC) #3
Benedikt Meurer
6 years, 4 months ago (2014-08-19 08:48:58 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as 23184 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698