chrome/browser/chromeos/policy/cloud_external_data_manager_base_unittest.cc - Issue 48713008: [sync] Allow FakeURLFetcher to return arbitrary HTTP response codes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/policy/cloud_external_data_manager_base_unittest.cc

Issue 48713008: [sync] Allow FakeURLFetcher to return arbitrary HTTP response codes (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebase Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/login/eula_browsertest.cc ('k') | chrome/browser/local_discovery/cloud_print_printer_list_unittest.cc » ('j') | chrome/browser/safe_browsing/client_side_detection_service_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/policy/cloud_external_data_manager_base_unittest.cc

diff --git a/chrome/browser/chromeos/policy/cloud_external_data_manager_base_unittest.cc b/chrome/browser/chromeos/policy/cloud_external_data_manager_base_unittest.cc

index acfd274fa321738f73964a85817750b16c9ed271..f087ace6287d4fd732cc0a992b1f154a44111277 100644

--- a/chrome/browser/chromeos/policy/cloud_external_data_manager_base_unittest.cc

+++ b/chrome/browser/chromeos/policy/cloud_external_data_manager_base_unittest.cc

@@ -24,6 +24,7 @@

#include "chrome/browser/policy/external_data_fetcher.h"

#include "chrome/browser/policy/policy_map.h"

#include "chrome/browser/policy/policy_types.h"

+#include "net/http/http_status_code.h"

#include "net/url_request/test_url_fetcher_factory.h"

#include "net/url_request/url_fetcher.h"

#include "net/url_request/url_fetcher_delegate.h"

@@ -237,7 +238,10 @@ void CloudExternalDataManagerBaseTest::SetFakeResponse(

const std::string& url,

const std::string& response_data,

bool success) {

achuithb 2013/11/01 20:57:04 Any reason not to fix this param instead?

Raghu Simha 2013/11/01 21:55:16 I only fixed calls to FakeURLFetcherFactory::SetFa

- fetcher_factory_.SetFakeResponse(GURL(url), response_data, success);

+ fetcher_factory_.SetFakeResponse(GURL(url),

+ response_data,

+ success ? net::HTTP_OK :

+ net::HTTP_INTERNAL_SERVER_ERROR);

}

// Verifies that when no valid external data reference has been set for a