chrome/browser/safe_browsing/client_side_detection_service_unittest.cc - Issue 48713008: [sync] Allow FakeURLFetcher to return arbitrary HTTP response codes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/safe_browsing/client_side_detection_service_unittest.cc

Issue 48713008: [sync] Allow FakeURLFetcher to return arbitrary HTTP response codes (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebase Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/chromeos/policy/cloud_external_data_manager_base_unittest.cc ('K') | « chrome/browser/profile_resetter/profile_resetter_unittest.cc ('k') | chrome/browser/safe_browsing/download_protection_service_unittest.cc » ('j') | chrome/service/cloud_print/printer_job_handler_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/safe_browsing/client_side_detection_service_unittest.cc

diff --git a/chrome/browser/safe_browsing/client_side_detection_service_unittest.cc b/chrome/browser/safe_browsing/client_side_detection_service_unittest.cc

index e32dcc45e45b2ca4e9187cf627ec01f469711c0b..b41d44a61c6ad9a48a8ab638d56a93d05963925d 100644

--- a/chrome/browser/safe_browsing/client_side_detection_service_unittest.cc

+++ b/chrome/browser/safe_browsing/client_side_detection_service_unittest.cc

@@ -17,6 +17,7 @@

#include "chrome/common/safe_browsing/csd.pb.h"

#include "content/public/test/test_browser_thread.h"

#include "crypto/sha2.h"

+#include "net/http/http_status_code.h"

#include "net/url_request/test_url_fetcher_factory.h"

#include "net/url_request/url_request_status.h"

#include "testing/gmock/include/gmock/gmock.h"

@@ -107,7 +108,9 @@ class ClientSideDetectionServiceTest : public testing::Test {

void SetModelFetchResponse(std::string response_data, bool success) {

factory_->SetFakeResponse(GURL(ClientSideDetectionService::kClientModelUrl),

- response_data, success);

+ response_data,

+ success ? net::HTTP_OK :

+ net::HTTP_INTERNAL_SERVER_ERROR);

}

void SetClientReportPhishingResponse(std::string response_data,

@@ -115,7 +118,9 @@ class ClientSideDetectionServiceTest : public testing::Test {

factory_->SetFakeResponse(

ClientSideDetectionService::GetClientReportUrl(

ClientSideDetectionService::kClientReportPhishingUrl),

- response_data, success);

+ response_data,

+ success ? net::HTTP_OK :

+ net::HTTP_INTERNAL_SERVER_ERROR);

}

void SetClientReportMalwareResponse(std::string response_data,

@@ -123,7 +128,9 @@ class ClientSideDetectionServiceTest : public testing::Test {

factory_->SetFakeResponse(

ClientSideDetectionService::GetClientReportUrl(

ClientSideDetectionService::kClientReportMalwareUrl),

- response_data, success);

+ response_data,

+ success ? net::HTTP_OK :

+ net::HTTP_INTERNAL_SERVER_ERROR);

}

int GetNumReports(std::queue<base::Time>* report_times) {