[sync] Allow FakeURLFetcher to return arbitrary HTTP response codes

chrome/browser/chromeos/policy/cloud_external_data_manager_base_unittest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/policy/cloud_external_data_manager_base.h"
 
 #include <map>
 #include <string>
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "base/files/scoped_temp_dir.h"
 #include "base/message_loop/message_loop.h"
 #include "base/message_loop/message_loop_proxy.h"
 #include "base/run_loop.h"
 #include "base/sha1.h"
 #include "base/stl_util.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/test/test_simple_task_runner.h"
 #include "base/values.h"
 #include "chrome/browser/chromeos/policy/cloud_external_data_store.h"
 #include "chrome/browser/policy/cloud/mock_cloud_policy_store.h"
 #include "chrome/browser/policy/cloud/resource_cache.h"
 #include "chrome/browser/policy/external_data_fetcher.h"
 #include "chrome/browser/policy/policy_map.h"
 #include "chrome/browser/policy/policy_types.h"
+#include "net/http/http_status_code.h"
 #include "net/url_request/test_url_fetcher_factory.h"
 #include "net/url_request/url_fetcher.h"
 #include "net/url_request/url_fetcher_delegate.h"
 #include "net/url_request/url_request_test_util.h"
 #include "policy/policy_constants.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include "url/gurl.h"
 
 namespace policy {
 
@@ skipping 192 matching lines @@
   callback_data_[id] = data.release();
 }
 
 void CloudExternalDataManagerBaseTest::FetchAll() {
   external_data_manager_->FetchAll();
 }
 
 void CloudExternalDataManagerBaseTest::SetFakeResponse(
     const std::string& url,
     const std::string& response_data,
     bool success) {

[achuithb, 2013/11/01 20:57:04]

Any reason not to fix this param instead?

[Raghu Simha, 2013/11/01 21:55:16]

I only fixed calls to FakeURLFetcherFactory::SetFakeResponse during my first
pass. Makes sense to fix this too. Done.

-  fetcher_factory_.SetFakeResponse(GURL(url), response_data, success);
+  fetcher_factory_.SetFakeResponse(GURL(url),
+                                   response_data,
+                                   success ? net::HTTP_OK :
+                                             net::HTTP_INTERNAL_SERVER_ERROR);
 }
 
 // Verifies that when no valid external data reference has been set for a
 // policy, the attempt to retrieve the external data fails immediately.
 TEST_F(CloudExternalDataManagerBaseTest, FailToFetchInvalid) {
   external_data_manager_->Connect(request_content_getter_);
 
   // Attempt to retrieve external data for |kStringPolicy|, which is a string
   // policy that does not reference any external data.
   external_data_manager_->Fetch(kStringPolicy, ConstructFetchCallback(0));
@@ skipping 474 matching lines @@
       ConstructMetadata(k20BytePolicyURL, base::SHA1HashString(k10ByteData)));
   cloud_policy_store_.NotifyStoreLoaded();
   base::RunLoop().RunUntilIdle();
   EXPECT_EQ(1u, callback_data_.size());
   ASSERT_TRUE(callback_data_[1]);
   EXPECT_EQ(k10ByteData, *callback_data_[1]);
   ResetCallbackData();
 }
 
 }  // namespace policy