Fixed the issue of insertion handle not clearing on single tap on empty field.

Fixed the issue of insertion handle not clearing on single tap on empty field.

This patch takes care of clearing the insertion handler and paste popup, when
we tap on empty edit field.

BUG=404652
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290349

[AKVT, 2014-08-18 16:38:26]

@jdduke PTAL this change.

[jdduke (slow), 2014-08-18 16:59:29]

Your colleague already posted a fix for this:
https://codereview.chromium.org/482723002/, which looks good except for needing
a unit test.  Please communicate with each other before working on the same
issue, thanks.

[jdduke (slow), 2014-08-18 17:00:50]

On 2014/08/18 16:59:29, jdduke wrote:
> Your colleague already posted a fix for this:
> https://codereview.chromium.org/482723002/, which looks good except for
needing
> a unit test.  Please communicate with each other before working on the same
> issue, thanks.

Nevermind, I should have looked at the code closer, this appears to be a
separate issue.

[jdduke (slow), 2014-08-18 17:08:33]

https://codereview.chromium.org/486763004/diff/1/content/browser/renderer_hos...
File content/browser/renderer_host/input/touch_selection_controller.cc (right):

https://codereview.chromium.org/486763004/diff/1/content/browser/renderer_hos...
content/browser/renderer_host/input/touch_selection_controller.cc:144:
DeactivateInsertion();
Nit: No need for braces. Also, please add a unit test.

[AKVT, 2014-08-18 18:18:21]

@jdduke PTAL.

https://codereview.chromium.org/486763004/diff/1/content/browser/renderer_hos...
File content/browser/renderer_host/input/touch_selection_controller.cc (right):

https://codereview.chromium.org/486763004/diff/1/content/browser/renderer_hos...
content/browser/renderer_host/input/touch_selection_controller.cc:144:
DeactivateInsertion();
On 2014/08/18 17:08:33, jdduke wrote:
> Nit: No need for braces. Also, please add a unit test.

Done. Thanks

[jdduke (slow), 2014-08-18 18:20:13]

lgtm

[AKVT, 2014-08-18 18:22:35]

The CQ bit was checked by ajith.v@samsung.com

[commit-bot: I haz the power, 2014-08-18 18:23:42]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/ajith.v@samsung.com/486763004/20001

[commit-bot: I haz the power, 2014-08-18 19:42:35]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  ios_dbg_simulator on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  mac_chromium_compile_dbg on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[commit-bot: I haz the power, 2014-08-18 20:08:28]

Committed patchset #2 (20001) as 290349