content/browser/renderer_host/input/touch_selection_controller.cc - Issue 486763004: Fixed the issue of insertion handle not clearing on single tap on empty field.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/input/touch_selection_controller.cc

Issue 486763004: Fixed the issue of insertion handle not clearing on single tap on empty field. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added unit testcase and fixed nits. Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/browser/renderer_host/input/touch_selection_controller.cc

diff --git a/content/browser/renderer_host/input/touch_selection_controller.cc b/content/browser/renderer_host/input/touch_selection_controller.cc

index d5380487e255bb339823fe0b39f112633f0d2ce6..f174067ede9cba1b7fde5b7221655a67dc532ecf 100644

--- a/content/browser/renderer_host/input/touch_selection_controller.cc

+++ b/content/browser/renderer_host/input/touch_selection_controller.cc

@@ -140,6 +140,8 @@ void TouchSelectionController::OnTapEvent() {

activate_selection_automatically_ = false;

DeactivateSelection();

ShowInsertionHandleAutomatically();

+ if (selection_empty_)

+ DeactivateInsertion();

ResetCachedValuesIfInactive();

}

« no previous file with comments | « no previous file | content/browser/renderer_host/input/touch_selection_controller_unittest.cc » ('j') | no next file with comments »