content/browser/renderer_host/input/touch_selection_controller_unittest.cc - Issue 486763004: Fixed the issue of insertion handle not clearing on single tap on empty field.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/input/touch_selection_controller_unittest.cc

Issue 486763004: Fixed the issue of insertion handle not clearing on single tap on empty field. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added unit testcase and fixed nits. Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/browser/renderer_host/input/touch_selection_controller_unittest.cc

diff --git a/content/browser/renderer_host/input/touch_selection_controller_unittest.cc b/content/browser/renderer_host/input/touch_selection_controller_unittest.cc

index f14860c4891cb67ddc5996eac90ce5ba218e83b4..d5aabbb0a565a283bd030efc82afffd8e56a89fb 100644

--- a/content/browser/renderer_host/input/touch_selection_controller_unittest.cc

+++ b/content/browser/renderer_host/input/touch_selection_controller_unittest.cc

@@ -256,6 +256,10 @@ TEST_F(TouchSelectionControllerTest, InsertionStaysHiddenIfEmptyRegionTapped) {

ChangeInsertion(insertion_rect, visible);

EXPECT_EQ(INSERTION_SHOWN, GetLastEventType());

EXPECT_EQ(insertion_rect.bottom_left(), GetLastEventAnchor());

+ // Single Tap on an empty edit field should clear insertion handle.

+ controller().OnTapEvent();

+ EXPECT_EQ(INSERTION_CLEARED, GetLastEventType());

}

TEST_F(TouchSelectionControllerTest, InsertionAppearsAfterTapFollowingTyping) {

« no previous file with comments | « content/browser/renderer_host/input/touch_selection_controller.cc ('k') | no next file » | no next file with comments »