Fix bookmark manager regression by allowing cr.ui.Menu#findMenuItem_ to return null.

Fix bookmark manager regression by allowing cr.ui.Menu#findMenuItem_ to return null.

R=arv@chromium.org
BUG=393873
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290961

[Dan Beam, 2014-08-20 01:20:31]

added a test as well

[arv (Not doing code reviews), 2014-08-20 16:46:48]

LGTM

https://codereview.chromium.org/485343004/diff/60001/chrome/test/data/webui/m...
File chrome/test/data/webui/menu_test.html (right):

https://codereview.chromium.org/485343004/diff/60001/chrome/test/data/webui/m...
chrome/test/data/webui/menu_test.html:8: cr.ui.decorate(menu, cr.ui.Menu);
You should not need to call decorate here

https://codereview.chromium.org/485343004/diff/60001/chrome/test/data/webui/m...
chrome/test/data/webui/menu_test.html:11: over.initEvent('mouseover', true,
true);
This is not really correct but I guess it is good enough for a test?

A better solution is to do

var over = new MouseEvent('mouseover', {
  bubbles: true,
  target: document.body
});
menu.dispatchEvent(over);

[Dan Beam, 2014-08-20 17:20:12]

https://codereview.chromium.org/485343004/diff/60001/chrome/test/data/webui/m...
File chrome/test/data/webui/menu_test.html (right):

https://codereview.chromium.org/485343004/diff/60001/chrome/test/data/webui/m...
chrome/test/data/webui/menu_test.html:8: cr.ui.decorate(menu, cr.ui.Menu);
On 2014/08/20 16:46:47, arv wrote:
> You should not need to call decorate here

https://code.google.com/p/chromium/codesearch#chromium/src/ui/webui/resources...

https://codereview.chromium.org/485343004/diff/60001/chrome/test/data/webui/m...
chrome/test/data/webui/menu_test.html:11: over.initEvent('mouseover', true,
true);
On 2014/08/20 16:46:47, arv wrote:
> This is not really correct but I guess it is good enough for a test?

ah, yeah, initMouseEvent... whoops.

> 
> A better solution is to do
> 
> var over = new MouseEvent('mouseover', {
>   bubbles: true,
>   target: document.body
> });
> menu.dispatchEvent(over);

Done.

[Dan Beam, 2014-08-20 17:20:54]

The CQ bit was checked by dbeam@chromium.org

[commit-bot: I haz the power, 2014-08-20 17:22:38]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/dbeam@chromium.org/485343004/100001

[commit-bot: I haz the power, 2014-08-20 18:49:26]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_chromium_x64_rel_swarming on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[commit-bot: I haz the power, 2014-08-20 20:40:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-20 20:40:57]

Try jobs failed on following builders:
  win_chromium_x64_rel_swarming on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[Dan Beam, 2014-08-20 21:39:49]

The CQ bit was checked by dbeam@chromium.org

[commit-bot: I haz the power, 2014-08-20 21:40:40]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/dbeam@chromium.org/485343004/100001

[commit-bot: I haz the power, 2014-08-20 23:31:09]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_chromium_x64_rel_swarming on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[commit-bot: I haz the power, 2014-08-21 00:40:33]

Committed patchset #2 (100001) as 290961