chrome/test/data/webui/menu_test.html - Issue 485343004: Fix bookmark manager regression by allowing cr.ui.Menu#findMenuItem_ to return null.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/test/data/webui/menu_test.html

Issue 485343004: Fix bookmark manager regression by allowing cr.ui.Menu#findMenuItem_ to return null. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: tests Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <html>

	3 <body>

	4 <script>

	5

	6 function testHandleMouseOver() {

	7 var menu = new cr.ui.Menu;

	8 cr.ui.decorate(menu, cr.ui.Menu);
	arv (Not doing code reviews) 2014/08/20 16:46:47 You should not need to call decorate here You should not need to call decorate here Dan Beam 2014/08/20 17:20:12 https://code.google.com/p/chromium/codesearch#chro Show quoted text On 2014/08/20 16:46:47, arv wrote: > You should not need to call decorate here https://code.google.com/p/chromium/codesearch#chromium/src/ui/webui/resources...
	9

	10 var over = cr.doc.createEvent('MouseEvent');

	11 over.initEvent('mouseover', true, true);
	arv (Not doing code reviews) 2014/08/20 16:46:47 This is not really correct but I guess it is good This is not really correct but I guess it is good enough for a test? A better solution is to do var over = new MouseEvent('mouseover', { bubbles: true, target: document.body }); menu.dispatchEvent(over); Dan Beam 2014/08/20 17:20:12 ah, yeah, initMouseEvent... whoops. Show quoted text On 2014/08/20 16:46:47, arv wrote: > This is not really correct but I guess it is good enough for a test? ah, yeah, initMouseEvent... whoops. Show quoted text > > A better solution is to do > > var over = new MouseEvent('mouseover', { > bubbles: true, > target: document.body > }); > menu.dispatchEvent(over); Done.
	12 over.target = document.body;

	13 menu.dispatchEvent(over);

	14 }

	15

	16 </script>

	17 </body>

	18 </html>

OLD	NEW

« no previous file with comments | « no previous file | chrome/test/data/webui/webui_resource_browsertest.cc » ('j') | no next file with comments »