ui/webui/resources/js/cr/ui/menu.js - Issue 485343004: Fix bookmark manager regression by allowing cr.ui.Menu#findMenuItem_ to return null.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/webui/resources/js/cr/ui/menu.js

Issue 485343004: Fix bookmark manager regression by allowing cr.ui.Menu#findMenuItem_ to return null. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: arv@ review Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ui/webui/resources/js/cr/ui/menu.js

diff --git a/ui/webui/resources/js/cr/ui/menu.js b/ui/webui/resources/js/cr/ui/menu.js

index cb3a7c672d96dc6b7fa3a5b4a23a0ed9e9830d0e..ea1088783cb6526399d97645c4518ba0d1c0fb0c 100644

--- a/ui/webui/resources/js/cr/ui/menu.js

+++ b/ui/webui/resources/js/cr/ui/menu.js

@@ -96,7 +96,7 @@ cr.define('cr.ui', function() {

while (el && el.parentNode != this) {

el = el.parentNode;

}

- return assertInstanceof(el, MenuItem);

+ return el ? assertInstanceof(el, MenuItem) : null;

/**

« no previous file with comments | « chrome/test/data/webui/webui_resource_browsertest.cc ('k') | no next file » | no next file with comments »