Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 485253002: DevTools: eye dropper, only pick on mouse down. (Closed)

Created:
6 years, 4 months ago by pfeldman
Modified:
6 years, 4 months ago
Reviewers:
dgozman
CC:
chromium-reviews, vsevik, jam, yurys, paulirish+reviews_chromium.org, darin-cc_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org, pfeldman
Project:
chromium
Visibility:
Public.

Description

DevTools: eye dropper, only pick on mouse down. BUG=404375 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290784

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M content/browser/devtools/renderer_overrides_handler.cc View 1 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
pfeldman
6 years, 4 months ago (2014-08-19 19:21:37 UTC) #1
dgozman
lgtm
6 years, 4 months ago (2014-08-20 04:25:59 UTC) #2
pfeldman
The CQ bit was checked by pfeldman@chromium.org
6 years, 4 months ago (2014-08-20 04:58:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pfeldman@chromium.org/485253002/20001
6 years, 4 months ago (2014-08-20 04:58:29 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_tests_recipe on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-20 06:35:50 UTC) #5
commit-bot: I haz the power
6 years, 4 months ago (2014-08-20 07:32:06 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (20001) as 290784

Powered by Google App Engine
This is Rietveld 408576698