Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(756)

Unified Diff: content/browser/devtools/renderer_overrides_handler.cc

Issue 485253002: DevTools: eye dropper, only pick on mouse down. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/devtools/renderer_overrides_handler.cc
diff --git a/content/browser/devtools/renderer_overrides_handler.cc b/content/browser/devtools/renderer_overrides_handler.cc
index 7d443b40e878b1fc890aa886742f6d6984928d9e..6a17540566e797659015b3f8d3f1d3f1a5a03094 100644
--- a/content/browser/devtools/renderer_overrides_handler.cc
+++ b/content/browser/devtools/renderer_overrides_handler.cc
@@ -953,7 +953,8 @@ bool RendererOverridesHandler::HandleMouseEvent(
if (color_picker_frame_.drawsNothing())
return true;
- if (event.button == blink::WebMouseEvent::ButtonLeft) {
+ if (event.button == blink::WebMouseEvent::ButtonLeft &&
+ event.type == blink::WebInputEvent::MouseDown) {
if (last_cursor_x_ < 0 || last_cursor_x_ >= color_picker_frame_.width() ||
last_cursor_y_ < 0 || last_cursor_y_ >= color_picker_frame_.height()) {
return true;
@@ -1017,6 +1018,7 @@ void RendererOverridesHandler::UpdateColorPickerCursor() {
kCursorSize * device_scale_factor,
kCursorSize * device_scale_factor));
canvas->scale(device_scale_factor, device_scale_factor);
+ canvas->translate(0.5f, 0.5f);
SkPaint paint;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698