DevTools: eye dropper, only pick on mouse down.

content/browser/devtools/renderer_overrides_handler.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/devtools/renderer_overrides_handler.h"
 
 #include <map>
 #include <string>
 
 #include "base/barrier_closure.h"
@@ skipping 935 matching lines @@
   }
 }
 
 bool RendererOverridesHandler::HandleMouseEvent(
     const blink::WebMouseEvent& event) {
   last_cursor_x_ = event.x;
   last_cursor_y_ = event.y;
   if (color_picker_frame_.drawsNothing())
     return true;
 
-  if (event.button == blink::WebMouseEvent::ButtonLeft) {
+  if (event.button == blink::WebMouseEvent::ButtonLeft &&
+      event.type == blink::WebInputEvent::MouseDown) {
     if (last_cursor_x_ < 0 || last_cursor_x_ >= color_picker_frame_.width() ||
         last_cursor_y_ < 0 || last_cursor_y_ >= color_picker_frame_.height()) {
       return true;
     }
 
     SkAutoLockPixels lock_image(color_picker_frame_);
     SkColor color = color_picker_frame_.getColor(last_cursor_x_,
                                                  last_cursor_y_);
     base::DictionaryValue* color_dict = new base::DictionaryValue();
     color_dict->SetInteger("r", SkColorGetR(color));
@@ skipping 43 matching lines @@
 #endif
 
   blink::WebScreenInfo screen_info;
   view->GetScreenInfo(&screen_info);
   double device_scale_factor = screen_info.deviceScaleFactor;
 
   skia::RefPtr<SkCanvas> canvas = skia::AdoptRef(SkCanvas::NewRasterN32(
       kCursorSize * device_scale_factor,
       kCursorSize * device_scale_factor));
   canvas->scale(device_scale_factor, device_scale_factor);
+  canvas->translate(0.5f, 0.5f);
 
   SkPaint paint;
 
   // Paint original spot with cross.
   if (kHotspotRadius) {
     paint.setStrokeWidth(1);
     paint.setAntiAlias(false);
     paint.setColor(SK_ColorDKGRAY);
     paint.setStyle(SkPaint::kStroke_Style);
 
@@ skipping 202 matching lines @@
     return command->InternalErrorResponse("Could not connect to view");
 
   if (event->type == WebInputEvent::MouseWheel)
     host_->ForwardWheelEvent(wheel_event);
   else
     host_->ForwardMouseEvent(mouse_event);
   return command->SuccessResponse(NULL);
 }
 
 }  // namespace content