|
|
This is the first step of a refactor I'm going to do to separate filling out the target and connecting the dependency tree. I'm hoping this refactor will dramatically simplify the threading code and fix some flakiness.
This change is mostly mechanical and replaces the lists of targets and config in the target object with a new pair that consists of a label and the pointer. Currently, they're still filled out at the same time.
The new structure also tracks the origin of the thing which simplifies some of the tracking in the describe function.
R=scottmg@chromium.org
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=232475
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+267 lines, -197 lines) |
Patch |
 |
M |
tools/gn/BUILD.gn
|
View
|
1
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
 |
M |
tools/gn/command_desc.cc
|
View
|
1
|
6 chunks |
+23 lines, -46 lines |
0 comments
|
Download
|
 |
M |
tools/gn/command_gyp.cc
|
View
|
1
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
 |
M |
tools/gn/config_values_extractors.h
|
View
|
1
2
3
|
2 chunks |
+10 lines, -2 lines |
0 comments
|
Download
|
 |
M |
tools/gn/gn.gyp
|
View
|
1
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
 |
M |
tools/gn/gyp_binary_target_writer.h
|
View
|
1
|
2 chunks |
+2 lines, -1 line |
0 comments
|
Download
|
 |
M |
tools/gn/gyp_binary_target_writer.cc
|
View
|
1
|
4 chunks |
+5 lines, -5 lines |
0 comments
|
Download
|
 |
A |
tools/gn/label_ptr.h
|
View
|
1
2
3
4
|
1 chunk |
+80 lines, -0 lines |
0 comments
|
Download
|
 |
M |
tools/gn/ninja_binary_target_writer.cc
|
View
|
1
|
2 chunks |
+5 lines, -5 lines |
0 comments
|
Download
|
 |
M |
tools/gn/ninja_binary_target_writer_unittest.cc
|
View
|
1
2
3
4
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
tools/gn/ninja_group_target_writer.cc
|
View
|
1
|
1 chunk |
+4 lines, -4 lines |
0 comments
|
Download
|
 |
M |
tools/gn/ninja_target_writer.cc
|
View
|
1
|
1 chunk |
+3 lines, -3 lines |
0 comments
|
Download
|
 |
M |
tools/gn/target.h
|
View
|
1
|
3 chunks |
+19 lines, -18 lines |
0 comments
|
Download
|
 |
M |
tools/gn/target.cc
|
View
|
1
|
6 chunks |
+27 lines, -28 lines |
0 comments
|
Download
|
 |
M |
tools/gn/target_generator.h
|
View
|
1
|
1 chunk |
+2 lines, -4 lines |
0 comments
|
Download
|
 |
M |
tools/gn/target_generator.cc
|
View
|
1
|
4 chunks |
+29 lines, -46 lines |
0 comments
|
Download
|
 |
M |
tools/gn/target_unittest.cc
|
View
|
1
2
3
4
|
6 chunks |
+26 lines, -26 lines |
0 comments
|
Download
|
 |
M |
tools/gn/value_extractors.h
|
View
|
1
|
2 chunks |
+9 lines, -1 line |
0 comments
|
Download
|
 |
M |
tools/gn/value_extractors.cc
|
View
|
1
|
2 chunks |
+18 lines, -5 lines |
0 comments
|
Download
|
Total messages: 3 (0 generated)
|