Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issue 48523006: GN: Separately track labels and origins for lists of stuff (Closed)

Created:
7 years, 1 month ago by brettw
Modified:
7 years, 1 month ago
Reviewers:
scottmg
CC:
chromium-reviews
Visibility:
Public.

Description

This is the first step of a refactor I'm going to do to separate filling out the target and connecting the dependency tree. I'm hoping this refactor will dramatically simplify the threading code and fix some flakiness. This change is mostly mechanical and replaces the lists of targets and config in the target object with a new pair that consists of a label and the pointer. Currently, they're still filled out at the same time. The new structure also tracks the origin of the thing which simplifies some of the tracking in the describe function. R=scottmg@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=232475

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+267 lines, -197 lines) Patch
M tools/gn/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
M tools/gn/command_desc.cc View 1 6 chunks +23 lines, -46 lines 0 comments Download
M tools/gn/command_gyp.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M tools/gn/config_values_extractors.h View 1 2 3 2 chunks +10 lines, -2 lines 0 comments Download
M tools/gn/gn.gyp View 1 1 chunk +1 line, -0 lines 0 comments Download
M tools/gn/gyp_binary_target_writer.h View 1 2 chunks +2 lines, -1 line 0 comments Download
M tools/gn/gyp_binary_target_writer.cc View 1 4 chunks +5 lines, -5 lines 0 comments Download
A tools/gn/label_ptr.h View 1 2 3 4 1 chunk +80 lines, -0 lines 0 comments Download
M tools/gn/ninja_binary_target_writer.cc View 1 2 chunks +5 lines, -5 lines 0 comments Download
M tools/gn/ninja_binary_target_writer_unittest.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M tools/gn/ninja_group_target_writer.cc View 1 1 chunk +4 lines, -4 lines 0 comments Download
M tools/gn/ninja_target_writer.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download
M tools/gn/target.h View 1 3 chunks +19 lines, -18 lines 0 comments Download
M tools/gn/target.cc View 1 6 chunks +27 lines, -28 lines 0 comments Download
M tools/gn/target_generator.h View 1 1 chunk +2 lines, -4 lines 0 comments Download
M tools/gn/target_generator.cc View 1 4 chunks +29 lines, -46 lines 0 comments Download
M tools/gn/target_unittest.cc View 1 2 3 4 6 chunks +26 lines, -26 lines 0 comments Download
M tools/gn/value_extractors.h View 1 2 chunks +9 lines, -1 line 0 comments Download
M tools/gn/value_extractors.cc View 1 2 chunks +18 lines, -5 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
brettw
7 years, 1 month ago (2013-10-29 18:34:29 UTC) #1
scottmg
lgtm
7 years, 1 month ago (2013-10-31 20:33:35 UTC) #2
brettw
7 years, 1 month ago (2013-11-01 22:00:05 UTC) #3
Message was sent while issue was closed.
Committed patchset #5 manually as r232475 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698