Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(639)

Unified Diff: tools/gn/gyp_binary_target_writer.cc

Issue 48523006: GN: Separately track labels and origins for lists of stuff (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/gn/gyp_binary_target_writer.h ('k') | tools/gn/label_ptr.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/gyp_binary_target_writer.cc
diff --git a/tools/gn/gyp_binary_target_writer.cc b/tools/gn/gyp_binary_target_writer.cc
index 7c4e7a394d25635c6554e0f755f39f0d892bf960..d8acdbd47f1a82517ca55b1dce97d7918b323ea9 100644
--- a/tools/gn/gyp_binary_target_writer.cc
+++ b/tools/gn/gyp_binary_target_writer.cc
@@ -97,12 +97,12 @@ std::string GetVCOptimization(std::vector<std::string>* cflags) {
// and adds them to the given result vector.
template<typename T>
void FillConfigListValues(
- const std::vector<const Config*>& configs,
+ const LabelConfigVector& configs,
const std::vector<T>& (ConfigValues::* getter)() const,
std::vector<T>* result) {
for (size_t config_i = 0; config_i < configs.size(); config_i++) {
const std::vector<T>& values =
- (configs[config_i]->config_values().*getter)();
+ (configs[config_i].ptr->config_values().*getter)();
for (size_t val_i = 0; val_i < values.size(); val_i++)
result->push_back(values[val_i]);
}
@@ -357,7 +357,7 @@ void GypBinaryTargetWriter::WriteSources(const Target* target, int indent) {
}
void GypBinaryTargetWriter::WriteDeps(const Target* target, int indent) {
- const std::vector<const Target*>& deps = target->deps();
+ const LabelTargetVector& deps = target->deps();
if (deps.empty())
return;
@@ -367,7 +367,7 @@ void GypBinaryTargetWriter::WriteDeps(const Target* target, int indent) {
Indent(indent) << "'dependencies': [\n";
for (size_t i = 0; i < deps.size(); i++) {
Indent(indent + kExtraIndent) << "'";
- EscapeStringToStream(out_, helper_.GetFullRefForTarget(deps[i]),
+ EscapeStringToStream(out_, helper_.GetFullRefForTarget(deps[i].ptr),
escape_options);
out_ << "',\n";
}
@@ -461,7 +461,7 @@ GypBinaryTargetWriter::Flags GypBinaryTargetWriter::FlagsFromTarget(
}
GypBinaryTargetWriter::Flags GypBinaryTargetWriter::FlagsFromConfigList(
- const std::vector<const Config*>& configs) const {
+ const LabelConfigVector& configs) const {
Flags ret;
#define EXTRACT(type, name) \
« no previous file with comments | « tools/gn/gyp_binary_target_writer.h ('k') | tools/gn/label_ptr.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698