Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(460)

Unified Diff: tools/gn/ninja_binary_target_writer.cc

Issue 48523006: GN: Separately track labels and origins for lists of stuff (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/gn/label_ptr.h ('k') | tools/gn/ninja_binary_target_writer_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/ninja_binary_target_writer.cc
diff --git a/tools/gn/ninja_binary_target_writer.cc b/tools/gn/ninja_binary_target_writer.cc
index 85dd0cd840e9c4d62446027dafee721e505e49f5..3a1d620ee1eccbadd93d63be2e2b07ed8a078b15 100644
--- a/tools/gn/ninja_binary_target_writer.cc
+++ b/tools/gn/ninja_binary_target_writer.cc
@@ -374,14 +374,14 @@ void NinjaBinaryTargetWriter::GetDeps(
std::set<OutputFile>* extra_object_files,
std::vector<const Target*>* linkable_deps,
std::vector<const Target*>* non_linkable_deps) const {
- const std::vector<const Target*>& deps = target_->deps();
+ const LabelTargetVector& deps = target_->deps();
const std::set<const Target*>& inherited = target_->inherited_libraries();
// Normal deps.
for (size_t i = 0; i < deps.size(); i++) {
- if (inherited.find(deps[i]) != inherited.end())
+ if (inherited.find(deps[i].ptr) != inherited.end())
continue; // Don't add dupes.
- ClassifyDependency(deps[i], extra_object_files,
+ ClassifyDependency(deps[i].ptr, extra_object_files,
linkable_deps, non_linkable_deps);
}
@@ -393,9 +393,9 @@ void NinjaBinaryTargetWriter::GetDeps(
}
// Data deps.
- const std::vector<const Target*>& datadeps = target_->datadeps();
+ const LabelTargetVector& datadeps = target_->datadeps();
for (size_t i = 0; i < datadeps.size(); i++)
- non_linkable_deps->push_back(datadeps[i]);
+ non_linkable_deps->push_back(datadeps[i].ptr);
}
void NinjaBinaryTargetWriter::ClassifyDependency(
« no previous file with comments | « tools/gn/label_ptr.h ('k') | tools/gn/ninja_binary_target_writer_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698