Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(983)

Unified Diff: pkg/analysis_server/lib/src/services/refactoring/rename_class_member.dart

Issue 485083004: Make RefactoringStatus a collection of generated RefactoringProblems. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/lib/src/services/refactoring/rename_class_member.dart
diff --git a/pkg/analysis_server/lib/src/services/refactoring/rename_class_member.dart b/pkg/analysis_server/lib/src/services/refactoring/rename_class_member.dart
index f68c26b00f401417cc077432cc53fd029fa47ded..6e8c6425331fbe564598b8dc0350e2dfe8be6a60 100644
--- a/pkg/analysis_server/lib/src/services/refactoring/rename_class_member.dart
+++ b/pkg/analysis_server/lib/src/services/refactoring/rename_class_member.dart
@@ -41,10 +41,8 @@ class RenameClassMemberRefactoringImpl extends RenameRefactoringImpl {
@override
Future<RefactoringStatus> checkFinalConditions() {
- _validator = new _RenameClassMemberValidator(
- searchEngine,
- element,
- newName);
+ _validator =
+ new _RenameClassMemberValidator(searchEngine, element, newName);
return _validator.validate();
}
@@ -108,8 +106,8 @@ class RenameClassMemberRefactoringImpl extends RenameRefactoringImpl {
}
}
// add edit
- SourceEdit edit = createReferenceEdit(reference, newName,
- id: _newPotentialId());
+ SourceEdit edit =
+ createReferenceEdit(reference, newName, id: _newPotentialId());
change.addEdit(reference.file, edit);
}
}).then((_) => change);
@@ -151,7 +149,7 @@ class _RenameClassMemberValidator {
elementClass.displayName,
getElementKindName(newNameMember),
newName),
- new RefactoringStatusContext.forElement(newNameMember));
+ createLocation_forElement(newNameMember));
}
// do chained computations
Set<ClassElement> superClasses = getSuperClasses(elementClass);
@@ -174,7 +172,7 @@ class _RenameClassMemberValidator {
getElementKindName(element),
getElementKindName(nameElement),
getElementQualifiedName(nameElement)),
- new RefactoringStatusContext.forElement(nameElement));
+ createLocation_forElement(nameElement));
}
// renamed Element is shadowed by member of subclass
if (subClasses.contains(nameClass)) {
@@ -184,7 +182,7 @@ class _RenameClassMemberValidator {
getElementKindName(element),
getElementKindName(nameElement),
getElementQualifiedName(nameElement)),
- new RefactoringStatusContext.forElement(nameElement));
+ createLocation_forElement(nameElement));
}
// renamed Element is shadowed by local
if (nameElement is LocalElement) {
@@ -201,7 +199,7 @@ class _RenameClassMemberValidator {
getElementKindName(element),
getElementKindName(localElement),
localElement.displayName),
- new RefactoringStatusContext.forMatch(reference));
+ createLocation_forMatch(reference));
}
}
}

Powered by Google App Engine
This is Rietveld 408576698