Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1397)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 484353004: Test tidying: use "escape" and "backspace" with eventSender.keyDown() (Closed)

Created:
6 years, 4 months ago by sof
Modified:
6 years, 4 months ago
Reviewers:
keishi, yosin_UTC9
CC:
blink-reviews, groby+blinkspell_chromium.org, tkent
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Test tidying: use "escape" and "backspace" with eventSender.keyDown() R=keishi@chromium.org,yosin@chromium.org BUG=392517 NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180765

Patch Set 1 #

Total comments: 12

Patch Set 2 : Nits addressed #

Patch Set 3 : More quoting consistency wibbles #

Unified diffs Side-by-side diffs Delta from patch set Stats (+143 lines, -143 lines) Patch
M LayoutTests/editing/deleting/delete-by-word-001.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/editing/deleting/delete-by-word-002.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/editing/deleting/delete-ligature-001.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/editing/deleting/delete-ligature-002.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/editing/deleting/delete-ligature-003.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/editing/deleting/skip-virama-001.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/editing/selection/5354455-1.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/editing/selection/context-menu-text-selection.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/editing/spelling/input-type-text.html View 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/editing/spelling/spelling-changed-text.html View 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/editing/spelling/spelling-double-clicked-word.html View 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/editing/spelling/spelling-double-clicked-word-with-underscores.html View 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/editing/spelling/spelling-exactly-selected-multiple-words.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/editing/spelling/spelling-exactly-selected-word.html View 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/editing/spelling/spelling-multiword-selection.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/editing/spelling/spelling-on-context-menu-key.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/editing/spelling/spelling-should-select-multiple-words.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/editing/spelling/spelling-should-select-single-word.html View 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/editing/spelling/spelling-subword-selection.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/editing/spelling/spelling-with-punctuation-selection.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/editing/spelling/spelling-with-underscore-selection.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/editing/spelling/spelling-with-whitespace-selection.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/editing/undo/undo-deleteWord.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/dom/HTMLDialogElement/dialog-canceling.html View 1 chunk +8 lines, -8 lines 0 comments Download
M LayoutTests/fast/events/drag-and-drop-autoscroll.html View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/events/key-events-in-input-text.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/events/menu-key-context-menu.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/events/menu-key-context-menu-document.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/events/special-key-events-in-input-text.html View 1 chunk +4 lines, -4 lines 0 comments Download
M LayoutTests/fast/forms/calendar-picker/calendar-picker-datetimelocal-with-step.html View 1 3 chunks +3 lines, -3 lines 0 comments Download
M LayoutTests/fast/forms/calendar-picker/calendar-picker-key-operations.html View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/fast/forms/calendar-picker/calendar-picker-with-step.html View 1 2 chunks +3 lines, -3 lines 0 comments Download
M LayoutTests/fast/forms/calendar-picker/month-picker-key-operations.html View 1 2 3 chunks +8 lines, -8 lines 0 comments Download
M LayoutTests/fast/forms/calendar-picker/month-picker-with-step.html View 1 2 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/forms/calendar-picker/week-picker-key-operations.html View 1 2 3 chunks +8 lines, -8 lines 0 comments Download
M LayoutTests/fast/forms/input-search-press-escape-key.html View 5 chunks +5 lines, -5 lines 0 comments Download
M LayoutTests/fast/forms/input-text-option-delete.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/forms/resources/input-live-pseudo-selectors.js View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/forms/resources/textarea-live-pseudo-selectors.js View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/forms/suggestion-picker/date-suggestion-picker-key-operations.html View 1 3 chunks +17 lines, -17 lines 0 comments Download
M LayoutTests/fast/forms/suggestion-picker/date-suggestion-picker-mouse-operations.html View 1 3 chunks +4 lines, -4 lines 0 comments Download
M LayoutTests/fast/forms/suggestion-picker/date-suggestion-picker-reset-value-after-reload.html View 1 2 chunks +4 lines, -4 lines 0 comments Download
M LayoutTests/fast/forms/suggestion-picker/date-suggestion-picker-step-attribute.html View 1 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-key-operations.html View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-mouse-operations.html View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-step-attribute.html View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M LayoutTests/fast/forms/suggestion-picker/month-suggestion-picker-key-operations.html View 1 2 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/forms/suggestion-picker/month-suggestion-picker-mouse-operations.html View 1 2 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/forms/suggestion-picker/month-suggestion-picker-step-attribute.html View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/fast/forms/suggestion-picker/time-suggestion-picker-key-operations.html View 1 3 chunks +17 lines, -17 lines 0 comments Download
M LayoutTests/fast/forms/suggestion-picker/time-suggestion-picker-mouse-operations.html View 1 3 chunks +5 lines, -5 lines 0 comments Download
M LayoutTests/fast/forms/suggestion-picker/time-suggestion-picker-step-attribute.html View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M LayoutTests/fast/forms/suggestion-picker/week-suggestion-picker-key-operations.html View 1 2 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/forms/suggestion-picker/week-suggestion-picker-mouse-operations.html View 1 2 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/forms/suggestion-picker/week-suggestion-picker-step-attribute.html View 1 2 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
sof
Please take a look.
6 years, 4 months ago (2014-08-22 07:05:55 UTC) #1
keishi
https://codereview.chromium.org/484353004/diff/1/LayoutTests/fast/events/drag-and-drop-autoscroll.html File LayoutTests/fast/events/drag-and-drop-autoscroll.html (right): https://codereview.chromium.org/484353004/diff/1/LayoutTests/fast/events/drag-and-drop-autoscroll.html#newcode53 LayoutTests/fast/events/drag-and-drop-autoscroll.html:53: eventSender.keyDown("escape"); nit: string literals in this file are using ...
6 years, 4 months ago (2014-08-22 07:22:33 UTC) #2
sof
Nits addressed.
6 years, 4 months ago (2014-08-22 07:44:31 UTC) #3
keishi
On 2014/08/22 07:44:31, sof wrote: > Nits addressed. LGTM
6 years, 4 months ago (2014-08-22 07:45:48 UTC) #4
sof
The CQ bit was checked by sigbjornf@opera.com
6 years, 4 months ago (2014-08-22 08:31:24 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/484353004/40001
6 years, 4 months ago (2014-08-22 08:32:05 UTC) #6
yosin_UTC9
LGTM Thanks for cleanup!
6 years, 4 months ago (2014-08-22 08:44:52 UTC) #7
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_chromium_gn_compile_rel on tryserver.blink ...
6 years, 4 months ago (2014-08-22 09:32:59 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-22 09:35:59 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/android_chromium_gn_compile_rel/builds/8254)
6 years, 4 months ago (2014-08-22 09:36:00 UTC) #10
sof
The CQ bit was checked by sigbjornf@opera.com
6 years, 4 months ago (2014-08-22 09:37:20 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/484353004/40001
6 years, 4 months ago (2014-08-22 09:37:35 UTC) #12
commit-bot: I haz the power
6 years, 4 months ago (2014-08-22 09:38:33 UTC) #13
Message was sent while issue was closed. 
Committed patchset #3 (40001) as 180765

Powered by Google App Engine
This is Rietveld 408576698