Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Unified Diff: LayoutTests/fast/dom/HTMLDialogElement/dialog-canceling.html

Issue 484353004: Test tidying: use "escape" and "backspace" with eventSender.keyDown() (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: More quoting consistency wibbles Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: LayoutTests/fast/dom/HTMLDialogElement/dialog-canceling.html
diff --git a/LayoutTests/fast/dom/HTMLDialogElement/dialog-canceling.html b/LayoutTests/fast/dom/HTMLDialogElement/dialog-canceling.html
index 8a9ef279e7914bcd70cc9da256f295d2e251a8e6..5c0d3984055391becf1a82007432317bde577c9f 100644
--- a/LayoutTests/fast/dom/HTMLDialogElement/dialog-canceling.html
+++ b/LayoutTests/fast/dom/HTMLDialogElement/dialog-canceling.html
@@ -63,36 +63,36 @@ function test() {
return;
debug('Top dialog event listener should prevent closing.');
- eventSender.keyDown("\x1B");
+ eventSender.keyDown("escape");
shouldBeTrue('topDialog.open');
shouldBeTrue('bottomDialog.open');
debug('Top dialog should close.');
- eventSender.keyDown("\x1B");
+ eventSender.keyDown("escape");
shouldBeFalse('topDialog.open');
shouldBeTrue('bottomDialog.open');
debug('Input should swallow Escape mechanism.');
swallowInput.focus();
- eventSender.keyDown("\x1B");
- eventSender.keyDown("\x1B");
- eventSender.keyDown("\x1B");
+ eventSender.keyDown("escape");
+ eventSender.keyDown("escape");
+ eventSender.keyDown("escape");
shouldBeFalse('topDialog.open');
shouldBeTrue('bottomDialog.open');
normalInput.focus();
debug('Bottom dialog event listener should prevent closing.');
- eventSender.keyDown("\x1B");
+ eventSender.keyDown("escape");
shouldBeFalse('topDialog.open');
shouldBeTrue('bottomDialog.open');
debug('Bottom dialog should close.');
- eventSender.keyDown("\x1B");
+ eventSender.keyDown("escape");
shouldBeFalse('topDialog.open');
shouldBeFalse('bottomDialog.open');
debug('Pressing Escape now should do nothing.');
- eventSender.keyDown("\x1B");
+ eventSender.keyDown("escape");
shouldBeFalse('topDialog.open');
shouldBeFalse('bottomDialog.open');
« no previous file with comments | « LayoutTests/editing/undo/undo-deleteWord.html ('k') | LayoutTests/fast/events/drag-and-drop-autoscroll.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698