Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Unified Diff: LayoutTests/fast/forms/suggestion-picker/time-suggestion-picker-mouse-operations.html

Issue 484353004: Test tidying: use "escape" and "backspace" with eventSender.keyDown() (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: More quoting consistency wibbles Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: LayoutTests/fast/forms/suggestion-picker/time-suggestion-picker-mouse-operations.html
diff --git a/LayoutTests/fast/forms/suggestion-picker/time-suggestion-picker-mouse-operations.html b/LayoutTests/fast/forms/suggestion-picker/time-suggestion-picker-mouse-operations.html
index dcf4f476f4652b8d8404776c0290ff1633c33d9e..c3949d09c8b295758a7e7f0215ecc44f60a80323 100644
--- a/LayoutTests/fast/forms/suggestion-picker/time-suggestion-picker-mouse-operations.html
+++ b/LayoutTests/fast/forms/suggestion-picker/time-suggestion-picker-mouse-operations.html
@@ -45,14 +45,14 @@ window.onload = function() {
function test1() {
debug('Check that page popup exists.');
- shouldBe('popupWindow.pagePopupController.toString()', '"[object PagePopupController]"');
+ shouldBeEqualToString('popupWindow.pagePopupController.toString()', '[object PagePopupController]');
debug('Check that page popup exists.');
- shouldBe('popupWindow.pagePopupController.toString()', '"[object PagePopupController]"');
+ shouldBeEqualToString('popupWindow.pagePopupController.toString()', '[object PagePopupController]');
debug('Check that hovering over an entry highlights it.');
hoverOverElement(popupWindow.document.querySelector(".suggestion-list-entry:nth-child(2)"));
- shouldBe('highlightedEntry()', '"01:02"');
+ shouldBeEqualToString('highlightedEntry()', '01:02');
debug('Check that moving the mouse outside the popup de-highlights entries.');
hoverOverElement(document.getElementById('description'));
@@ -65,7 +65,7 @@ function test1() {
function test1AfterClosing() {
shouldBeNull('document.getElementById("mock-page-popup")');
- shouldBe('document.getElementById("time").value', '"01:03"');
+ shouldBeEqualToString('document.getElementById("time").value', '01:03');
openPicker($('time'), test2);
}
@@ -89,7 +89,7 @@ function test2() {
shouldBeTrue('scrollTopBeforeWheelEvent > scrollTopAfterWheelEvent');
popupWindow.focus();
- eventSender.keyDown('\x1B');
+ eventSender.keyDown('escape');
waitUntilClosing(test2AfterClosing);
}

Powered by Google App Engine
This is Rietveld 408576698