Issue 483093004: Rename QuicConnection::OnPacketSent to OnWriteError, to reflect it's

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 483093004: Rename QuicConnection::OnPacketSent to OnWriteError, to reflect it's (Closed)

Created:
6 years, 4 months ago by ramant (doing other things)

Modified:
6 years, 4 months ago

Reviewers:
Ryan Hamilton

CC:
chromium-reviews, cbentzel+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@Refactor_async_write_behavior_73648585

Project:
chromium

Visibility:
Public.

More Reviews

Description

Rename QuicConnection::OnPacketSent to OnWriteError, to reflect it's actual functionality, and to only be called when there is an error. Clean up some logging when packets are sent. Merge internal change: 73651039 R=rch@chromium.org

Patch Set 1 #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+30 lines, -31 lines)			Patch
M	net/quic/quic_connection.h	View	1 chunk	+3 lines, -2 lines	0 comments	Download
M	net/quic/quic_connection.cc	View	5 chunks	+17 lines, -24 lines	0 comments	Download
M	net/quic/quic_connection_test.cc	View	2 chunks	+4 lines, -2 lines	0 comments	Download
M	net/quic/quic_default_packet_writer.cc	View	1 chunk	+3 lines, -2 lines	0 comments	Download
M	net/quic/quic_per_connection_packet_writer.cc	View	1 chunk	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages