net/quic/quic_per_connection_packet_writer.cc - Issue 483093004: Rename QuicConnection::OnPacketSent to OnWriteError, to reflect it's

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/quic/quic_per_connection_packet_writer.cc

Issue 483093004: Rename QuicConnection::OnPacketSent to OnWriteError, to reflect it's (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@Refactor_async_write_behavior_73648585

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/quic/quic_per_connection_packet_writer.cc

diff --git a/net/quic/quic_per_connection_packet_writer.cc b/net/quic/quic_per_connection_packet_writer.cc

index 6347bc201df632e68de7aac05a19a63584179edf..4943320c3ef3aac09909af56aa5fb3ef6a83c9d0 100644

--- a/net/quic/quic_per_connection_packet_writer.cc

+++ b/net/quic/quic_per_connection_packet_writer.cc

@@ -44,7 +44,9 @@ void QuicPerConnectionPacketWriter::SetWritable() {

}

void QuicPerConnectionPacketWriter::OnWriteComplete(WriteResult result) {

- connection_->OnPacketSent(result);

+ if (result.status == WRITE_STATUS_ERROR) {

+ connection_->OnWriteError(result.error_code);

+ }

}

} // namespace net

« no previous file with comments | « net/quic/quic_default_packet_writer.cc ('k') | no next file » | no next file with comments »