net/quic/quic_default_packet_writer.cc - Issue 483093004: Rename QuicConnection::OnPacketSent to OnWriteError, to reflect it's

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/quic/quic_default_packet_writer.cc

Issue 483093004: Rename QuicConnection::OnPacketSent to OnWriteError, to reflect it's (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@Refactor_async_write_behavior_73648585

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/quic/quic_default_packet_writer.cc

diff --git a/net/quic/quic_default_packet_writer.cc b/net/quic/quic_default_packet_writer.cc

index 5dd80c6fd3dfd25c72e37aff5f5cac309d82c618..6453846635ebd3408fc10c0fe7ea0b10f4126c66 100644

--- a/net/quic/quic_default_packet_writer.cc

+++ b/net/quic/quic_default_packet_writer.cc

@@ -65,8 +65,9 @@ void QuicDefaultPacketWriter::SetWritable() {

void QuicDefaultPacketWriter::OnWriteComplete(int rv) {

DCHECK_NE(rv, ERR_IO_PENDING);

write_blocked_ = false;

- WriteResult result(rv < 0 ? WRITE_STATUS_ERROR : WRITE_STATUS_OK, rv);

- connection_->OnPacketSent(result);

+ if (rv < 0) {

+ connection_->OnWriteError(rv);

+ }

connection_->OnCanWrite();

}

« no previous file with comments | « net/quic/quic_connection_test.cc ('k') | net/quic/quic_per_connection_packet_writer.cc » ('j') | no next file with comments »