pkg/analysis_server/test/integration/server/set_subscriptions_test.dart - Issue 482573004: Change analysis server protocol to omit empty lists when optional.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analysis_server/test/integration/server/set_subscriptions_test.dart

Issue 482573004: Change analysis server protocol to omit empty lists when optional. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/analysis_server/test/integration/server/set_subscriptions_invalid_service_test.dart ('k') | pkg/analysis_server/test/search/type_hierarchy_test.dart » ('j') | pkg/analysis_server/tool/spec/spec_input.html » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/analysis_server/test/integration/server/set_subscriptions_test.dart

diff --git a/pkg/analysis_server/test/integration/server/set_subscriptions_test.dart b/pkg/analysis_server/test/integration/server/set_subscriptions_test.dart

index 51f974a44120dd5fc51ea3149f3d05c8b23ed10d..990be25a13b6d00fab43a8d5510e137008f7a363 100644

--- a/pkg/analysis_server/test/integration/server/set_subscriptions_test.dart

+++ b/pkg/analysis_server/test/integration/server/set_subscriptions_test.dart

@@ -24,7 +24,7 @@ class Test extends AbstractAnalysisServerIntegrationTest {

analysisBegun.complete();

}

});

- return sendServerSetSubscriptions([]).then((_) {

+ return sendServerSetSubscriptions().then((_) {

String pathname = sourcePath('test.dart');

writeFile(pathname, '''

main() {

@@ -35,7 +35,7 @@ main() {

// received.

return analysisBegun.future.then((_) {

expect(statusReceived, isFalse);

- return sendServerSetSubscriptions(['STATUS']).then((_) {

+ return sendServerSetSubscriptions(subscriptions: ['STATUS']).then((_) {

// Tickle test.dart just in case analysis has already completed.

writeFile(pathname, '''

main() {