Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(279)

Side by Side Diff: pkg/analysis_server/test/integration/server/set_subscriptions_test.dart

Issue 482573004: Change analysis server protocol to omit empty lists when optional. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library test.integration.server.set.subscriptions; 5 library test.integration.server.set.subscriptions;
6 6
7 import 'dart:async'; 7 import 'dart:async';
8 8
9 import 'package:analysis_testing/reflective_tests.dart'; 9 import 'package:analysis_testing/reflective_tests.dart';
10 import 'package:unittest/unittest.dart'; 10 import 'package:unittest/unittest.dart';
11 11
12 import '../integration_tests.dart'; 12 import '../integration_tests.dart';
13 13
14 @ReflectiveTestCase() 14 @ReflectiveTestCase()
15 class Test extends AbstractAnalysisServerIntegrationTest { 15 class Test extends AbstractAnalysisServerIntegrationTest {
16 test_setSubscriptions() { 16 test_setSubscriptions() {
17 bool statusReceived = false; 17 bool statusReceived = false;
18 Completer analysisBegun = new Completer(); 18 Completer analysisBegun = new Completer();
19 onServerStatus.listen((_) { 19 onServerStatus.listen((_) {
20 statusReceived = true; 20 statusReceived = true;
21 }); 21 });
22 onAnalysisErrors.listen((_) { 22 onAnalysisErrors.listen((_) {
23 if (!analysisBegun.isCompleted) { 23 if (!analysisBegun.isCompleted) {
24 analysisBegun.complete(); 24 analysisBegun.complete();
25 } 25 }
26 }); 26 });
27 return sendServerSetSubscriptions([]).then((_) { 27 return sendServerSetSubscriptions().then((_) {
28 String pathname = sourcePath('test.dart'); 28 String pathname = sourcePath('test.dart');
29 writeFile(pathname, ''' 29 writeFile(pathname, '''
30 main() { 30 main() {
31 var x; 31 var x;
32 }'''); 32 }''');
33 standardAnalysisSetup(subscribeStatus: false); 33 standardAnalysisSetup(subscribeStatus: false);
34 // Analysis should begin, but no server.status notification should be 34 // Analysis should begin, but no server.status notification should be
35 // received. 35 // received.
36 return analysisBegun.future.then((_) { 36 return analysisBegun.future.then((_) {
37 expect(statusReceived, isFalse); 37 expect(statusReceived, isFalse);
38 return sendServerSetSubscriptions(['STATUS']).then((_) { 38 return sendServerSetSubscriptions(subscriptions: ['STATUS']).then((_) {
39 // Tickle test.dart just in case analysis has already completed. 39 // Tickle test.dart just in case analysis has already completed.
40 writeFile(pathname, ''' 40 writeFile(pathname, '''
41 main() { 41 main() {
42 var y; 42 var y;
43 }'''); 43 }''');
44 // Analysis should eventually complete, and we should be notified 44 // Analysis should eventually complete, and we should be notified
45 // about it. 45 // about it.
46 return analysisFinished; 46 return analysisFinished;
47 }); 47 });
48 }); 48 });
49 }); 49 });
50 } 50 }
51 } 51 }
52 52
53 main() { 53 main() {
54 runReflectiveTests(Test); 54 runReflectiveTests(Test);
55 } 55 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698