pkg/analysis_server/test/integration/server/set_subscriptions_invalid_service_test.dart - Issue 482573004: Change analysis server protocol to omit empty lists when optional.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analysis_server/test/integration/server/set_subscriptions_invalid_service_test.dart

Issue 482573004: Change analysis server protocol to omit empty lists when optional. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/analysis_server/test/integration/search/get_type_hierarchy_test.dart ('k') | pkg/analysis_server/test/integration/server/set_subscriptions_test.dart » ('j') | pkg/analysis_server/tool/spec/spec_input.html » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/analysis_server/test/integration/server/set_subscriptions_invalid_service_test.dart

diff --git a/pkg/analysis_server/test/integration/server/set_subscriptions_invalid_service_test.dart b/pkg/analysis_server/test/integration/server/set_subscriptions_invalid_service_test.dart

index a5d24ed304a2ea05f7cda1c739dd9b14e3440587..b35f0e1532e1952d5f3b265e3073205f3d38ae26 100644

--- a/pkg/analysis_server/test/integration/server/set_subscriptions_invalid_service_test.dart

+++ b/pkg/analysis_server/test/integration/server/set_subscriptions_invalid_service_test.dart

@@ -14,7 +14,8 @@ class Test extends AbstractAnalysisServerIntegrationTest {

test_setSubscriptions_invalidService() {

// TODO(paulberry): verify that if an invalid service is specified, the

// current subscriptions are unchanged.

- return sendServerSetSubscriptions(['bogus'], checkTypes: false).then((_) {

+ return sendServerSetSubscriptions(subscriptions: ['bogus'],

+ checkTypes: false).then((_) {

fail('setSubscriptions should have produced an error');

}, onError: (error) {

// The expected error occurred.