Issue 479723003: Don't add extra items to sheriff-o-matic history.

Issue 479723003: Don't add extra items to sheriff-o-matic history. (Closed)

Created:
6 years, 4 months ago by michaelpg

Modified:
6 years, 4 months ago

Reviewers:
ojan

CC:
ojan, blink-reviews, dsinclair, jochen (gone - plz use gerrit), leviw_travelin_and_unemployed, michaelpg, szager1, teravest

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

Don't add extra items to sheriff-o-matic history. BUG=404324 R=ojan@chromium.org NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180402

Patch Set 2 : #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+26 lines, -9 lines)			Patch
A +	Tools/GardeningServer/test/placeholder.html	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
M	Tools/GardeningServer/ui/ct-embedded-flakiness-dashboard.html	View	1	1 chunk	+2 lines, -1 line	0 comments	Download
M	Tools/GardeningServer/ui/test/ct-embedded-flakiness-dashboard-tests.html	View		1 chunk	+25 lines, -9 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

ojan

lgtm assuming you manually tested changing from one test to another with an actual cross-origin ...

6 years, 4 months ago (2014-08-16 01:40:57 UTC) #2

michaelpg

Thanks. https://codereview.chromium.org/479723003/diff/1/Tools/GardeningServer/ui/ct-embedded-flakiness-dashboard.html File Tools/GardeningServer/ui/ct-embedded-flakiness-dashboard.html (right): https://codereview.chromium.org/479723003/diff/1/Tools/GardeningServer/ui/ct-embedded-flakiness-dashboard.html#newcode35 Tools/GardeningServer/ui/ct-embedded-flakiness-dashboard.html:35: this.$.iframe.contentWindow.location.replace(this.test.embeddedFlakinessDashboardURL(this.tree)); On 2014/08/16 01:40:56, ojan-only-code-yellow-reviews wrote: > Add ...

6 years, 4 months ago (2014-08-16 02:05:45 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/michaelpg@chromium.org/479723003/20001

6 years, 4 months ago (2014-08-16 02:06:48 UTC) #5

commit-bot: I haz the power

6 years, 4 months ago (2014-08-16 02:07:09 UTC) #6

Message was sent while issue was closed.

Committed patchset #2 (20001) as 180402

Expand Messages | Collapse Messages