Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(524)

Unified Diff: Tools/GardeningServer/ui/test/ct-embedded-flakiness-dashboard-tests.html

Issue 479723003: Don't add extra items to sheriff-o-matic history. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Tools/GardeningServer/ui/ct-embedded-flakiness-dashboard.html ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Tools/GardeningServer/ui/test/ct-embedded-flakiness-dashboard-tests.html
diff --git a/Tools/GardeningServer/ui/test/ct-embedded-flakiness-dashboard-tests.html b/Tools/GardeningServer/ui/test/ct-embedded-flakiness-dashboard-tests.html
index 26ac18ac6531389358541708e02f52e59048e541..382b5d4c74d0daf9a29f2f5970502cd9f8e289d2 100644
--- a/Tools/GardeningServer/ui/test/ct-embedded-flakiness-dashboard-tests.html
+++ b/Tools/GardeningServer/ui/test/ct-embedded-flakiness-dashboard-tests.html
@@ -12,17 +12,33 @@ found in the LICENSE file.
var assert = chai.assert;
describe('ct-embedded-flakiness-dashboard', function() {
- it('should point the iframe to the dashboard', function(done) {
- var failure = new CTFailure('foo_tests', 'foo/bar.html');
- var tree = "blink";
- var embeddedFlakinessDashboard = document.createElement('ct-embedded-flakiness-dashboard');
- embeddedFlakinessDashboard.test = failure;
- embeddedFlakinessDashboard.tree = tree;
- setTimeout(function() {
+ describe('iframe location', function() {
+ var embeddedFlakinessDashboard;
+
+ after(function() {
+ document.body.removeChild(embeddedFlakinessDashboard);
+ });
+
+ it('should point the iframe to the dashboard', function(done) {
+ var failure = new CTFailure('foo_tests', 'foo/bar.html');
+ failure.embeddedFlakinessDashboardURL = function(tree) {
+ return 'placeholder.html?' + this.flakinessDashboardURL(tree) + '&showChrome=false';
+ }
+
+ var tree = "blink";
+ embeddedFlakinessDashboard = document.createElement('ct-embedded-flakiness-dashboard');
+ embeddedFlakinessDashboard.hidden = true;
+ embeddedFlakinessDashboard.test = failure;
+ embeddedFlakinessDashboard.tree = tree;
+ document.body.appendChild(embeddedFlakinessDashboard);
+
var iframe = embeddedFlakinessDashboard.shadowRoot.querySelector('#iframe');
- assert.equal(iframe.src, failure.embeddedFlakinessDashboardURL(tree));
- done();
+ iframe.addEventListener('load', function() {
+ assert.include(iframe.contentWindow.location.href,
+ failure.embeddedFlakinessDashboardURL(tree));
+ done();
+ });
});
});
« no previous file with comments | « Tools/GardeningServer/ui/ct-embedded-flakiness-dashboard.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698