Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(621)

Side by Side Diff: Tools/GardeningServer/ui/ct-embedded-flakiness-dashboard.html

Issue 479723003: Don't add extra items to sheriff-o-matic history. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 <!-- 1 <!--
2 Copyright 2014 The Chromium Authors. All rights reserved. 2 Copyright 2014 The Chromium Authors. All rights reserved.
3 Use of this source code is governed by a BSD-style license that can be 3 Use of this source code is governed by a BSD-style license that can be
4 found in the LICENSE file. 4 found in the LICENSE file.
5 --> 5 -->
6 6
7 <polymer-element name="ct-embedded-flakiness-dashboard" attributes="test tree"> 7 <polymer-element name="ct-embedded-flakiness-dashboard" attributes="test tree">
8 <template> 8 <template>
9 <style> 9 <style>
10 :host { 10 :host {
(...skipping 14 matching lines...) Expand all
25 ready: function() { 25 ready: function() {
26 window.addEventListener('message', function(event) { 26 window.addEventListener('message', function(event) {
27 if (event.data.command != 'heightChanged') 27 if (event.data.command != 'heightChanged')
28 return; 28 return;
29 29
30 this.$.iframe.style.height = event.data.height + 'px'; 30 this.$.iframe.style.height = event.data.height + 'px';
31 }.bind(this)); 31 }.bind(this));
32 }, 32 },
33 33
34 testChanged: function() { 34 testChanged: function() {
35 this.$.iframe.src = this.test.embeddedFlakinessDashboardURL(this.tree); 35 this.$.iframe.contentWindow.location.replace(this.test.embeddedFlakiness DashboardURL(this.tree));
ojan 2014/08/16 01:40:56 Add a comment explaining why we use replace? Also
michaelpg 2014/08/16 02:05:45 It works, but it's weird. You can get a reference
36 }, 36 },
37 37
38 }); 38 });
39 </script> 39 </script>
40 </polymer-element> 40 </polymer-element>
OLDNEW
« no previous file with comments | « Tools/GardeningServer/test/placeholder.html ('k') | Tools/GardeningServer/ui/test/ct-embedded-flakiness-dashboard-tests.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698