Declaring the weak_ptr_factory in proper order.

Declaring the weak_ptr_factory in proper order.

Cleaning up weak_ptr_factory destruction order.
WeakPtrFactory should remain the last member so it'll be destroyed and
invalidate its weak pointers before any other members are destroyed.

BUG=303818
Committed: https://crrev.com/0139e0db513ef473efe0d13c64d76b2c4baf6599
Cr-Commit-Position: refs/heads/master@{#291885}

[ARUNKK, 2014-08-18 12:15:47]

Declaring the weak_ptr_factory in proper order.
	
Cleaning up weak_ptr_factory destruction order.
WeakPtrFactory should remain the last member so it'll be destroyed and 
invalidate its weak pointers before any other members are destroyed.

Please refer the 
https://code.google.com/p/chromium/issues/detail?id=303818

[vivekg, 2014-08-18 12:27:43]

You can remove signed off line as its not required.

Also can you make sure that your name appers on the CLA and you include your
name in src/AUTHORS file? 

Make BUG=303818 in the description as well so that we can refer back to the meta
bug for detailed discussions.

[ARUNKK, 2014-08-18 12:31:18]

PTAL

[Sikugu_, 2014-08-20 05:34:29]

https://codereview.chromium.org/479183002/diff/1/cc/resources/image_copy_rast...
File cc/resources/image_copy_raster_worker_pool.h (right):

https://codereview.chromium.org/479183002/diff/1/cc/resources/image_copy_rast...
cc/resources/image_copy_raster_worker_pool.h:114:
raster_finished_weak_ptr_factory_;
are there any other left out places in cc where these changes are needed? If so
we can hadle in this patch. please check.

[ARUNKK, 2014-08-20 06:14:57]

On 2014/08/20 05:34:29, Sikugu_ wrote:
>
https://codereview.chromium.org/479183002/diff/1/cc/resources/image_copy_rast...
> File cc/resources/image_copy_raster_worker_pool.h (right):
> 
>
https://codereview.chromium.org/479183002/diff/1/cc/resources/image_copy_rast...
> cc/resources/image_copy_raster_worker_pool.h:114:
> raster_finished_weak_ptr_factory_;
> are there any other left out places in cc where these changes are needed? If
so
> we can hadle in this patch. please check.

Verified in the "src/cc", all are taken care in this patch.
PTAL

[ARUNKK, 2014-08-26 05:59:41]

kulkarni.a@samsung.com changed reviewers:
+ dmichael@chromium.org, reveman@chromium.org
- kphanee@chromium.org, l.gombos@samsung.com, sivagunturi@chromium.org,
sohan.jyoti@samsung.com, vivek.vg@samsung.com

[ARUNKK, 2014-08-26 05:59:41]

reveman@chromium.org: Please review changes in "src/cc" module.

[reveman, 2014-08-26 08:48:45]

lgtm with nit

https://codereview.chromium.org/479183002/diff/20001/cc/resources/image_raste...
File cc/resources/image_raster_worker_pool.h (right):

https://codereview.chromium.org/479183002/diff/20001/cc/resources/image_raste...
cc/resources/image_raster_worker_pool.h:71: Task::Vector completed_tasks_;
nit: please add blank line here to be consistent with other files

[ARUNKK, 2014-08-26 09:26:07]

On 2014/08/26 08:48:45, reveman wrote:
> lgtm with nit
> 
>
https://codereview.chromium.org/479183002/diff/20001/cc/resources/image_raste...
> File cc/resources/image_raster_worker_pool.h (right):
> 
>
https://codereview.chromium.org/479183002/diff/20001/cc/resources/image_raste...
> cc/resources/image_raster_worker_pool.h:71: Task::Vector completed_tasks_;
> nit: please add blank line here to be consistent with other files

incorporated the nit comment
PTAL.

[reveman, 2014-08-26 09:38:19]

lgtm

[ARUNKK, 2014-08-26 09:46:37]

The CQ bit was checked by kulkarni.a@samsung.com

[commit-bot: I haz the power, 2014-08-26 09:47:44]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/kulkarni.a@samsung.com/479183002/40001

[commit-bot: I haz the power, 2014-08-26 11:30:24]

Committed patchset #3 (40001) as 708373278851fa22f0121ea89ac7dab7652366ee

[commit-bot: I haz the power, 2014-09-10 02:42:09]

Patchset 3 (id:??) landed as
https://crrev.com/0139e0db513ef473efe0d13c64d76b2c4baf6599
Cr-Commit-Position: refs/heads/master@{#291885}