cc/resources/image_raster_worker_pool.h - Issue 479183002: Declaring the weak_ptr_factory in proper order.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/resources/image_raster_worker_pool.h

Issue 479183002: Declaring the weak_ptr_factory in proper order. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: incorporated the 'nit' comment Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: cc/resources/image_raster_worker_pool.h

diff --git a/cc/resources/image_raster_worker_pool.h b/cc/resources/image_raster_worker_pool.h

index 39ac7237266ced9c3a7c2c47d0ab31f1467abbd9..77f53a807ba74ed6a1e3fb5e7df12c576882745b 100644

--- a/cc/resources/image_raster_worker_pool.h

+++ b/cc/resources/image_raster_worker_pool.h

@@ -62,8 +62,6 @@ class CC_EXPORT ImageRasterWorkerPool : public RasterWorkerPool,

bool raster_tasks_pending_;

bool raster_tasks_required_for_activation_pending_;

- base::WeakPtrFactory<ImageRasterWorkerPool> raster_finished_weak_ptr_factory_;

scoped_refptr<RasterizerTask> raster_finished_task_;

scoped_refptr<RasterizerTask> raster_required_for_activation_finished_task_;

@@ -72,6 +70,8 @@ class CC_EXPORT ImageRasterWorkerPool : public RasterWorkerPool,

TaskGraph graph_;

Task::Vector completed_tasks_;

+ base::WeakPtrFactory<ImageRasterWorkerPool> raster_finished_weak_ptr_factory_;

DISALLOW_COPY_AND_ASSIGN(ImageRasterWorkerPool);

};