cc/resources/image_raster_worker_pool.h - Issue 479183002: Declaring the weak_ptr_factory in proper order.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: cc/resources/image_raster_worker_pool.h

Issue 479183002: Declaring the weak_ptr_factory in proper order. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: incorporated the 'nit' comment Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « cc/resources/image_copy_raster_worker_pool.h ('k') | cc/resources/pixel_buffer_raster_worker_pool.h » ('j') | no next file with comments »

OLD	NEW
1 // Copyright 2013 The Chromium Authors. All rights reserved.	1 // Copyright 2013 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef CC_RESOURCES_IMAGE_RASTER_WORKER_POOL_H_	5 #ifndef CC_RESOURCES_IMAGE_RASTER_WORKER_POOL_H_

6 #define CC_RESOURCES_IMAGE_RASTER_WORKER_POOL_H_	6 #define CC_RESOURCES_IMAGE_RASTER_WORKER_POOL_H_

7	7

8 #include "base/memory/weak_ptr.h"	8 #include "base/memory/weak_ptr.h"

9 #include "base/values.h"	9 #include "base/values.h"

10 #include "cc/resources/raster_worker_pool.h"	10 #include "cc/resources/raster_worker_pool.h"

(...skipping 44 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
55	55

56 scoped_refptr<base::SequencedTaskRunner> task_runner_;	56 scoped_refptr<base::SequencedTaskRunner> task_runner_;

57 TaskGraphRunner* task_graph_runner_;	57 TaskGraphRunner* task_graph_runner_;

58 const NamespaceToken namespace_token_;	58 const NamespaceToken namespace_token_;

59 RasterizerClient* client_;	59 RasterizerClient* client_;

60 ResourceProvider* resource_provider_;	60 ResourceProvider* resource_provider_;

61	61

62 bool raster_tasks_pending_;	62 bool raster_tasks_pending_;

63 bool raster_tasks_required_for_activation_pending_;	63 bool raster_tasks_required_for_activation_pending_;

64	64

65 base::WeakPtrFactory<ImageRasterWorkerPool> raster_finished_weak_ptr_factory_;

66

67 scoped_refptr<RasterizerTask> raster_finished_task_;	65 scoped_refptr<RasterizerTask> raster_finished_task_;

68 scoped_refptr<RasterizerTask> raster_required_for_activation_finished_task_;	66 scoped_refptr<RasterizerTask> raster_required_for_activation_finished_task_;

69	67

70 // Task graph used when scheduling tasks and vector used to gather	68 // Task graph used when scheduling tasks and vector used to gather

71 // completed tasks.	69 // completed tasks.

72 TaskGraph graph_;	70 TaskGraph graph_;

73 Task::Vector completed_tasks_;	71 Task::Vector completed_tasks_;

74	72

	73 base::WeakPtrFactory<ImageRasterWorkerPool> raster_finished_weak_ptr_factory_;

	74

75 DISALLOW_COPY_AND_ASSIGN(ImageRasterWorkerPool);	75 DISALLOW_COPY_AND_ASSIGN(ImageRasterWorkerPool);

76 };	76 };

77	77

78 } // namespace cc	78 } // namespace cc

79	79

80 #endif // CC_RESOURCES_IMAGE_RASTER_WORKER_POOL_H_	80 #endif // CC_RESOURCES_IMAGE_RASTER_WORKER_POOL_H_

OLD	NEW