Source/core/html/shadow/SpinButtonElement.cpp - Issue 478433002: Avoid RenderObject::paintInvalidationForWholeRenderer() if possible

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/shadow/SpinButtonElement.cpp

Issue 478433002: Avoid RenderObject::paintInvalidationForWholeRenderer() if possible (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: TestExpectations Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/html/shadow/SpinButtonElement.cpp

diff --git a/Source/core/html/shadow/SpinButtonElement.cpp b/Source/core/html/shadow/SpinButtonElement.cpp

index 2195609af9b86cf768549070a11bea8066daabae..2679b01427916925c7f7f0708cec24ae2251b9b9 100644

--- a/Source/core/html/shadow/SpinButtonElement.cpp

+++ b/Source/core/html/shadow/SpinButtonElement.cpp

@@ -125,7 +125,7 @@ void SpinButtonElement::defaultEventHandler(Event* event)

UpDownState oldUpDownState = m_upDownState;

m_upDownState = (local.y() < box->height() / 2) ? Up : Down;

if (m_upDownState != oldUpDownState)

- renderer()->paintInvalidationForWholeRenderer();

+ renderer()->setShouldDoFullPaintInvalidation(true);

} else {

releaseCapture();

m_upDownState = Indeterminate;