De-duplicate job_settings parsing code.

printing/printing_context.h

Index: printing/printing_context.h
diff --git a/printing/printing_context.h b/printing/printing_context.h
index f4ba7ad759d4b7bfb59d12cc2361d05f350ec31f..3bd7ba5cd5ba4f759d60520979a1b5a22c65e52a 100644
--- a/printing/printing_context.h
+++ b/printing/printing_context.h
@@ -51,11 +51,14 @@ class PRINTING_EXPORT PrintingContext {
   // default device settings.
   virtual Result UseDefaultSettings() = 0;
 
-  // Updates printer related settings. |job_settings| contains all print job
-  // settings information. |ranges| has the new page range settings.
-  virtual Result UpdatePrinterSettings(
-      const base::DictionaryValue& job_settings,
-      const PageRanges& ranges) = 0;
+  // Updates printer settings.
+  // |pdf_only| is true if implementation needs to generate PDF without actual
+  // printing. In this case implementation may avoid setup of native print
+  // system. Ex. "save to pdf" or Cloud Print.
+  // |external_preview| is true if pdf is going to be opened in external
+  // preview.

[Lei Zhang, 2013/10/28 23:40:23]

You may want to give Preview.app as an example.

[Vitaly Buka (NO REVIEWS), 2013/10/29 00:31:21]

Done.

+  virtual Result UpdatePrinterSettings(bool target_is_pdf,
+                                       bool external_preview) = 0;
 
   // Updates Print Settings. |job_settings| contains all print job
   // settings information. |ranges| has the new page range settings.