Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(447)

Unified Diff: printing/printed_document.cc

Issue 47823002: De-duplicate job_settings parsing code. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Review Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: printing/printed_document.cc
diff --git a/printing/printed_document.cc b/printing/printed_document.cc
index e2cd74a9deab4cddff36076edf51fb14056acd26..1f08ac1c73cd6632117ded2caff5d493d847c6c4 100644
--- a/printing/printed_document.cc
+++ b/printing/printed_document.cc
@@ -51,10 +51,10 @@ PrintedDocument::PrintedDocument(const PrintSettings& settings,
immutable_(settings, source, cookie) {
// Records the expected page count if a range is setup.
- if (!settings.ranges.empty()) {
+ if (!settings.ranges().empty()) {
// If there is a range, set the number of page
- for (unsigned i = 0; i < settings.ranges.size(); ++i) {
- const PageRange& range = settings.ranges[i];
+ for (unsigned i = 0; i < settings.ranges().size(); ++i) {
+ const PageRange& range = settings.ranges()[i];
mutable_.expected_page_count_ += range.to - range.from + 1;
}
}
@@ -153,7 +153,7 @@ void PrintedDocument::set_page_count(int max_page) {
base::AutoLock lock(lock_);
DCHECK_EQ(0, mutable_.page_count_);
mutable_.page_count_ = max_page;
- if (immutable_.settings_.ranges.empty()) {
+ if (immutable_.settings_.ranges().empty()) {
mutable_.expected_page_count_ = max_page;
} else {
// If there is a range, don't bother since expected_page_count_ is already

Powered by Google App Engine
This is Rietveld 408576698