De-duplicate job_settings parsing code.

printing/printing_context.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef PRINTING_PRINTING_CONTEXT_H_
 #define PRINTING_PRINTING_CONTEXT_H_
 
 #include <string>
 
 #include "base/basictypes.h"
@@ skipping 33 matching lines @@
   // asynchronous printing API.
   virtual void AskUserForSettings(gfx::NativeView parent_view,
                                   int max_pages,
                                   bool has_selection,
                                   const PrintSettingsCallback& callback) = 0;
 
   // Selects the user's default printer and format. Updates the context with the
   // default device settings.
   virtual Result UseDefaultSettings() = 0;
 
-  // Updates printer related settings. |job_settings| contains all print job
-  // settings information. |ranges| has the new page range settings.
-  virtual Result UpdatePrinterSettings(
-      const base::DictionaryValue& job_settings,
-      const PageRanges& ranges) = 0;
+  // Updates printer settings.
+  // |pdf_only| is true if implementation needs to generate PDF without actual
+  // printing. In this case implementation may avoid setup of native print
+  // system. Ex. "save to pdf" or Cloud Print.
+  // |external_preview| is true if pdf is going to be opened in external
+  // preview.

[Lei Zhang, 2013/10/28 23:40:23]

You may want to give Preview.app as an example.

[Vitaly Buka (NO REVIEWS), 2013/10/29 00:31:21]

Done.

+  virtual Result UpdatePrinterSettings(bool target_is_pdf,
+                                       bool external_preview) = 0;
 
   // Updates Print Settings. |job_settings| contains all print job
   // settings information. |ranges| has the new page range settings.
   Result UpdatePrintSettings(const base::DictionaryValue& job_settings,
                              const PageRanges& ranges);
 
   // Initializes with predefined settings.
   virtual Result InitWithSettings(const PrintSettings& settings) = 0;
 
   // Does platform specific setup of the printer before the printing. Signal the
@@ skipping 59 matching lines @@
   // The application locale.
   std::string app_locale_;
 
  private:
   DISALLOW_COPY_AND_ASSIGN(PrintingContext);
 };
 
 }  // namespace printing
 
 #endif  // PRINTING_PRINTING_CONTEXT_H_