Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 478043006: Rewrite StoreIC handling using the LookupIterator. Continued from patch 494153002 (Closed)

Created:
6 years, 4 months ago by Toon Verwaest
Modified:
6 years, 4 months ago
Reviewers:
Yang, Jakob Kummerow
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Rewrite StoreIC handling using the LookupIterator. Continued from patch 494153002 BUG= R=yangguo@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=23305

Patch Set 1 #

Patch Set 2 : #

Total comments: 3

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+376 lines, -514 lines) Patch
M src/arm/stub-cache-arm.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/arm64/stub-cache-arm64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ia32/stub-cache-ia32.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ic.h View 1 5 chunks +14 lines, -30 lines 0 comments Download
M src/ic.cc View 1 2 3 21 chunks +220 lines, -310 lines 0 comments Download
M src/lookup.h View 6 chunks +23 lines, -3 lines 0 comments Download
M src/lookup.cc View 1 6 chunks +51 lines, -21 lines 0 comments Download
M src/lookup-inl.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/mips/stub-cache-mips.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/mips64/stub-cache-mips64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/objects.h View 3 chunks +0 lines, -8 lines 0 comments Download
M src/objects.cc View 1 16 chunks +39 lines, -118 lines 0 comments Download
M src/runtime.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/stub-cache.h View 3 chunks +3 lines, -3 lines 0 comments Download
M src/stub-cache.cc View 5 chunks +17 lines, -14 lines 0 comments Download
M src/x64/stub-cache-x64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/x87/stub-cache-x87.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Toon Verwaest
PTAL
6 years, 4 months ago (2014-08-21 18:29:16 UTC) #1
Yang
lgtm. https://codereview.chromium.org/478043006/diff/180001/src/ic.cc File src/ic.cc (right): https://codereview.chromium.org/478043006/diff/180001/src/ic.cc#newcode967 src/ic.cc:967: ->map() wow. git cl format slightly drunk? https://codereview.chromium.org/478043006/diff/180001/src/ic.cc#newcode1238 ...
6 years, 4 months ago (2014-08-22 11:21:11 UTC) #2
Toon Verwaest
Addressed comment https://codereview.chromium.org/478043006/diff/180001/src/ic.cc File src/ic.cc (right): https://codereview.chromium.org/478043006/diff/180001/src/ic.cc#newcode1238 src/ic.cc:1238: Handle<JSObject> receiver = Handle<JSObject>::cast(it->GetReceiver()); On 2014/08/22 11:21:10, ...
6 years, 4 months ago (2014-08-22 11:33:29 UTC) #3
Toon Verwaest
6 years, 4 months ago (2014-08-22 11:38:37 UTC) #4
Message was sent while issue was closed. 
Committed patchset #4 manually as 23305 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698