Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Side by Side Diff: src/x64/stub-cache-x64.cc

Issue 478043006: Rewrite StoreIC handling using the LookupIterator. Continued from patch 494153002 (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/stub-cache.cc ('k') | src/x87/stub-cache-x87.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #if V8_TARGET_ARCH_X64 7 #if V8_TARGET_ARCH_X64
8 8
9 #include "src/arguments.h" 9 #include "src/arguments.h"
10 #include "src/codegen.h" 10 #include "src/codegen.h"
(...skipping 498 matching lines...) Expand 10 before | Expand all | Expand 10 after
509 EMIT_REMEMBERED_SET, smi_check); 509 EMIT_REMEMBERED_SET, smi_check);
510 } 510 }
511 } 511 }
512 512
513 // Return the value (register rax). 513 // Return the value (register rax).
514 DCHECK(value_reg.is(rax)); 514 DCHECK(value_reg.is(rax));
515 __ ret(0); 515 __ ret(0);
516 } 516 }
517 517
518 518
519 void NamedStoreHandlerCompiler::GenerateStoreField(LookupResult* lookup, 519 void NamedStoreHandlerCompiler::GenerateStoreField(LookupIterator* lookup,
520 Register value_reg, 520 Register value_reg,
521 Label* miss_label) { 521 Label* miss_label) {
522 DCHECK(lookup->representation().IsHeapObject()); 522 DCHECK(lookup->representation().IsHeapObject());
523 __ JumpIfSmi(value_reg, miss_label); 523 __ JumpIfSmi(value_reg, miss_label);
524 HeapType::Iterator<Map> it = lookup->GetFieldType()->Classes(); 524 HeapType::Iterator<Map> it = lookup->GetFieldType()->Classes();
525 Label do_store; 525 Label do_store;
526 while (true) { 526 while (true) {
527 __ CompareMap(value_reg, it.Current()); 527 __ CompareMap(value_reg, it.Current());
528 it.Advance(); 528 it.Advance();
529 if (it.Done()) { 529 if (it.Done()) {
(...skipping 595 matching lines...) Expand 10 before | Expand all | Expand 10 after
1125 // ----------------------------------- 1125 // -----------------------------------
1126 TailCallBuiltin(masm, Builtins::kKeyedLoadIC_Miss); 1126 TailCallBuiltin(masm, Builtins::kKeyedLoadIC_Miss);
1127 } 1127 }
1128 1128
1129 1129
1130 #undef __ 1130 #undef __
1131 1131
1132 } } // namespace v8::internal 1132 } } // namespace v8::internal
1133 1133
1134 #endif // V8_TARGET_ARCH_X64 1134 #endif // V8_TARGET_ARCH_X64
OLDNEW
« no previous file with comments | « src/stub-cache.cc ('k') | src/x87/stub-cache-x87.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698