Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(589)

Side by Side Diff: src/x87/stub-cache-x87.cc

Issue 478043006: Rewrite StoreIC handling using the LookupIterator. Continued from patch 494153002 (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/x64/stub-cache-x64.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #if V8_TARGET_ARCH_X87 7 #if V8_TARGET_ARCH_X87
8 8
9 #include "src/codegen.h" 9 #include "src/codegen.h"
10 #include "src/ic-inl.h" 10 #include "src/ic-inl.h"
(...skipping 549 matching lines...) Expand 10 before | Expand all | Expand 10 after
560 smi_check); 560 smi_check);
561 } 561 }
562 } 562 }
563 563
564 // Return the value (register eax). 564 // Return the value (register eax).
565 DCHECK(value_reg.is(eax)); 565 DCHECK(value_reg.is(eax));
566 __ ret(0); 566 __ ret(0);
567 } 567 }
568 568
569 569
570 void NamedStoreHandlerCompiler::GenerateStoreField(LookupResult* lookup, 570 void NamedStoreHandlerCompiler::GenerateStoreField(LookupIterator* lookup,
571 Register value_reg, 571 Register value_reg,
572 Label* miss_label) { 572 Label* miss_label) {
573 DCHECK(lookup->representation().IsHeapObject()); 573 DCHECK(lookup->representation().IsHeapObject());
574 __ JumpIfSmi(value_reg, miss_label); 574 __ JumpIfSmi(value_reg, miss_label);
575 HeapType::Iterator<Map> it = lookup->GetFieldType()->Classes(); 575 HeapType::Iterator<Map> it = lookup->GetFieldType()->Classes();
576 Label do_store; 576 Label do_store;
577 while (true) { 577 while (true) {
578 __ CompareMap(value_reg, it.Current()); 578 __ CompareMap(value_reg, it.Current());
579 it.Advance(); 579 it.Advance();
580 if (it.Done()) { 580 if (it.Done()) {
(...skipping 596 matching lines...) Expand 10 before | Expand all | Expand 10 after
1177 // ----------------------------------- 1177 // -----------------------------------
1178 TailCallBuiltin(masm, Builtins::kKeyedLoadIC_Miss); 1178 TailCallBuiltin(masm, Builtins::kKeyedLoadIC_Miss);
1179 } 1179 }
1180 1180
1181 1181
1182 #undef __ 1182 #undef __
1183 1183
1184 } } // namespace v8::internal 1184 } } // namespace v8::internal
1185 1185
1186 #endif // V8_TARGET_ARCH_X87 1186 #endif // V8_TARGET_ARCH_X87
OLDNEW
« no previous file with comments | « src/x64/stub-cache-x64.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698