Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 477633002: Rename various Geolocation bits for clarity and consistency. (Closed)

Created:
6 years, 4 months ago by Michael van Ouwerkerk
Modified:
6 years, 4 months ago
Reviewers:
timvolodine
CC:
chromium-reviews, darin-cc_chromium.org, jam, Michael van Ouwerkerk
Project:
chromium
Visibility:
Public.

Description

Rename various Geolocation bits for clarity and consistency. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289678

Patch Set 1 #

Patch Set 2 : One more rename. #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -46 lines) Patch
M content/browser/geolocation/location_arbitrator_impl.h View 2 chunks +5 lines, -5 lines 0 comments Download
M content/browser/geolocation/location_arbitrator_impl.cc View 3 chunks +7 lines, -8 lines 0 comments Download
M content/browser/geolocation/network_location_provider.h View 1 chunk +7 lines, -7 lines 0 comments Download
M content/browser/geolocation/network_location_provider.cc View 3 chunks +8 lines, -8 lines 0 comments Download
M content/browser/geolocation/network_location_provider_unittest.cc View 2 chunks +4 lines, -5 lines 2 comments Download
M content/browser/geolocation/network_location_request.h View 1 1 chunk +3 lines, -3 lines 0 comments Download
M content/browser/geolocation/network_location_request.cc View 1 6 chunks +8 lines, -8 lines 0 comments Download
M content/browser/geolocation/wifi_data_provider_common_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Michael van Ouwerkerk
Hi Tim, please take a look :-)
6 years, 4 months ago (2014-08-14 14:50:42 UTC) #1
timvolodine
lgtm https://codereview.chromium.org/477633002/diff/20001/content/browser/geolocation/network_location_provider_unittest.cc File content/browser/geolocation/network_location_provider_unittest.cc (right): https://codereview.chromium.org/477633002/diff/20001/content/browser/geolocation/network_location_provider_unittest.cc#newcode476 content/browser/geolocation/network_location_provider_unittest.cc:476: provider->SetUpdateCallback(base::Bind( nit: I actually prefer the previous formatting, ...
6 years, 4 months ago (2014-08-14 17:32:28 UTC) #2
Michael van Ouwerkerk
Thanks Tim! https://codereview.chromium.org/477633002/diff/20001/content/browser/geolocation/network_location_provider_unittest.cc File content/browser/geolocation/network_location_provider_unittest.cc (right): https://codereview.chromium.org/477633002/diff/20001/content/browser/geolocation/network_location_provider_unittest.cc#newcode476 content/browser/geolocation/network_location_provider_unittest.cc:476: provider->SetUpdateCallback(base::Bind( On 2014/08/14 17:32:28, timvolodine wrote: > ...
6 years, 4 months ago (2014-08-14 17:36:14 UTC) #3
Michael van Ouwerkerk
The CQ bit was checked by mvanouwerkerk@chromium.org
6 years, 4 months ago (2014-08-14 17:36:18 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mvanouwerkerk@chromium.org/477633002/20001
6 years, 4 months ago (2014-08-14 17:38:02 UTC) #5
commit-bot: I haz the power
6 years, 4 months ago (2014-08-14 19:47:24 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (20001) as 289678

Powered by Google App Engine
This is Rietveld 408576698