Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Unified Diff: content/browser/geolocation/network_location_provider.cc

Issue 477633002: Rename various Geolocation bits for clarity and consistency. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: One more rename. Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/geolocation/network_location_provider.cc
diff --git a/content/browser/geolocation/network_location_provider.cc b/content/browser/geolocation/network_location_provider.cc
index 2a9d7c8a3b8711126b4bd6e5fa7cb8a3d73e48c6..0cc7f8fc6853cd9906630fb472fb151b737d2e65 100644
--- a/content/browser/geolocation/network_location_provider.cc
+++ b/content/browser/geolocation/network_location_provider.cc
@@ -110,7 +110,7 @@ NetworkLocationProvider::NetworkLocationProvider(
: access_token_store_(access_token_store),
wifi_data_provider_(NULL),
wifi_data_update_callback_(
- base::Bind(&NetworkLocationProvider::WifiDataUpdateAvailable,
+ base::Bind(&NetworkLocationProvider::OnWifiDataUpdate,
base::Unretained(this))),
is_wifi_data_complete_(false),
access_token_(access_token),
@@ -120,10 +120,11 @@ NetworkLocationProvider::NetworkLocationProvider(
// Create the position cache.
position_cache_.reset(new PositionCache());
- NetworkLocationRequest::LocationResponseCallback callback =
- base::Bind(&NetworkLocationProvider::LocationResponseAvailable,
- base::Unretained(this));
- request_.reset(new NetworkLocationRequest(url_context_getter, url, callback));
+ request_.reset(new NetworkLocationRequest(
+ url_context_getter,
+ url,
+ base::Bind(&NetworkLocationProvider::OnLocationResponse,
+ base::Unretained(this))));
}
NetworkLocationProvider::~NetworkLocationProvider() {
@@ -153,14 +154,13 @@ void NetworkLocationProvider::OnPermissionGranted() {
}
}
-void NetworkLocationProvider::WifiDataUpdateAvailable(
- WifiDataProvider* provider) {
+void NetworkLocationProvider::OnWifiDataUpdate(WifiDataProvider* provider) {
DCHECK(provider == wifi_data_provider_);
is_wifi_data_complete_ = wifi_data_provider_->GetData(&wifi_data_);
OnWifiDataUpdated();
}
-void NetworkLocationProvider::LocationResponseAvailable(
+void NetworkLocationProvider::OnLocationResponse(
const Geoposition& position,
bool server_error,
const base::string16& access_token,

Powered by Google App Engine
This is Rietveld 408576698