Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(580)

Unified Diff: content/browser/geolocation/location_arbitrator_impl.cc

Issue 477633002: Rename various Geolocation bits for clarity and consistency. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: One more rename. Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/geolocation/location_arbitrator_impl.cc
diff --git a/content/browser/geolocation/location_arbitrator_impl.cc b/content/browser/geolocation/location_arbitrator_impl.cc
index b8ed8c49bf51b0b2714d79f496241e0d177fcf33..ef20a0ce4686cc02d9d8e2f54cbb212ecdfe09ed 100644
--- a/content/browser/geolocation/location_arbitrator_impl.cc
+++ b/content/browser/geolocation/location_arbitrator_impl.cc
@@ -28,9 +28,9 @@ const int64 LocationArbitratorImpl::kFixStaleTimeoutMilliseconds =
LocationArbitratorImpl::LocationArbitratorImpl(
const LocationUpdateCallback& callback)
- : callback_(callback),
- provider_callback_(
- base::Bind(&LocationArbitratorImpl::LocationUpdateAvailable,
+ : arbitrator_update_callback_(callback),
+ provider_update_callback_(
+ base::Bind(&LocationArbitratorImpl::OnLocationUpdate,
base::Unretained(this))),
position_provider_(NULL),
is_permission_granted_(false),
@@ -116,15 +116,14 @@ void LocationArbitratorImpl::RegisterProvider(
LocationProvider* provider) {
if (!provider)
return;
- provider->SetUpdateCallback(provider_callback_);
+ provider->SetUpdateCallback(provider_update_callback_);
if (is_permission_granted_)
provider->OnPermissionGranted();
providers_.push_back(provider);
}
-void LocationArbitratorImpl::LocationUpdateAvailable(
- const LocationProvider* provider,
- const Geoposition& new_position) {
+void LocationArbitratorImpl::OnLocationUpdate(const LocationProvider* provider,
+ const Geoposition& new_position) {
DCHECK(new_position.Validate() ||
new_position.error_code != Geoposition::ERROR_CODE_NONE);
if (!IsNewPositionBetter(position_, new_position,
@@ -132,7 +131,7 @@ void LocationArbitratorImpl::LocationUpdateAvailable(
return;
position_provider_ = provider;
position_ = new_position;
- callback_.Run(position_);
+ arbitrator_update_callback_.Run(position_);
}
AccessTokenStore* LocationArbitratorImpl::NewAccessTokenStore() {

Powered by Google App Engine
This is Rietveld 408576698