Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 47623002: Fix more warnings on linux (Closed)

Created:
7 years, 1 month ago by lgombos
Modified:
7 years, 1 month ago
Reviewers:
Nico, dglazkov, Inactive
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Disble delete-non-virtual-dtor #

Patch Set 3 : Rebase #

Patch Set 4 : Fix tests. #

Total comments: 1

Patch Set 5 : Fix sign-compare and do not yet turn on -Wall. #

Total comments: 5

Patch Set 6 : Fix RenderImage.cpp. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+96 lines, -115 lines) Patch
M Source/bindings/v8/ScriptDebugServer.cpp View 1 2 1 chunk +1 line, -3 lines 0 comments Download
M Source/core/dom/DOMURLUtils.h View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/dom/DOMURLUtilsReadOnly.h View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/dom/Document.cpp View 1 2 3 4 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/dom/QualifiedName.cpp View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/canvas/WebGLRenderingContext.cpp View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M Source/core/platform/animation/TimingFunction.h View 1 2 3 4 1 chunk +4 lines, -5 lines 0 comments Download
M Source/core/platform/graphics/WidthCache.h View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M Source/core/platform/graphics/chromium/ImageDecodingStore.h View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/platform/graphics/chromium/ImageDecodingStore.cpp View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/platform/graphics/chromium/ImageDecodingStoreTest.cpp View 1 2 3 19 chunks +34 lines, -34 lines 0 comments Download
M Source/core/platform/graphics/chromium/ImageFrameGeneratorTest.cpp View 1 2 3 10 chunks +36 lines, -36 lines 0 comments Download
M Source/core/platform/graphics/harfbuzz/HarfBuzzShaper.cpp View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderImage.cpp View 1 2 3 4 5 2 chunks +0 lines, -5 lines 0 comments Download
M Source/core/rendering/RenderObject.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/crypto/HmacKeyParams.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/websockets/NewWebSocketChannelImpl.cpp View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M Source/platform/text/TextBreakIteratorICU.cpp View 1 2 3 4 1 chunk +0 lines, -11 lines 0 comments Download
M Source/wtf/HashMapTest.cpp View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M Source/wtf/HashTable.h View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M Source/wtf/HashTraits.h View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
lgombos
It seems that at some point warnings were treated as errors - see http://trac.webkit.org/changeset/68691/trunk/WebKit/chromium/WebKit.gyp . ...
7 years, 1 month ago (2013-10-28 14:10:37 UTC) #1
Nico
not lgtm, should fix exising warnings first
7 years, 1 month ago (2013-10-28 19:14:03 UTC) #2
lgombos
Fix more warnings on Linux to match to chromium warning levels. Disable sign-compare and unused-function ...
7 years, 1 month ago (2013-10-29 11:05:38 UTC) #3
Inactive
https://codereview.chromium.org/47623002/diff/200001/Source/core/platform/animation/TimingFunction.h File Source/core/platform/animation/TimingFunction.h (right): https://codereview.chromium.org/47623002/diff/200001/Source/core/platform/animation/TimingFunction.h#newcode277 Source/core/platform/animation/TimingFunction.h:277: const Segment* segment = 0; Maybe we could rewrite ...
7 years, 1 month ago (2013-10-29 13:56:20 UTC) #4
lgombos
It seems that tuning on -Wall causes some failures on chromium side as well, so ...
7 years, 1 month ago (2013-10-29 15:40:09 UTC) #5
Nico
lgtm Thanks! https://codereview.chromium.org/47623002/diff/290001/Source/core/platform/graphics/chromium/ImageDecodingStore.h File Source/core/platform/graphics/chromium/ImageDecodingStore.h (right): https://codereview.chromium.org/47623002/diff/290001/Source/core/platform/graphics/chromium/ImageDecodingStore.h#newcode119 Source/core/platform/graphics/chromium/ImageDecodingStore.h:119: int cacheEntries(); nit: Is it easy to ...
7 years, 1 month ago (2013-10-29 15:51:30 UTC) #6
lgombos
https://codereview.chromium.org/47623002/diff/290001/Source/core/platform/graphics/chromium/ImageDecodingStore.h File Source/core/platform/graphics/chromium/ImageDecodingStore.h (right): https://codereview.chromium.org/47623002/diff/290001/Source/core/platform/graphics/chromium/ImageDecodingStore.h#newcode119 Source/core/platform/graphics/chromium/ImageDecodingStore.h:119: int cacheEntries(); On 2013/10/29 15:51:30, Nico wrote: > nit: ...
7 years, 1 month ago (2013-10-29 17:33:15 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/l.gombos@samsung.com/47623002/370001
7 years, 1 month ago (2013-10-29 17:33:51 UTC) #8
commit-bot: I haz the power
Retried try job too often on blink_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=blink_presubmit&number=10095
7 years, 1 month ago (2013-10-29 17:55:18 UTC) #9
Inactive
LGTM for bindings/. Still needs an OWNER for modules/.
7 years, 1 month ago (2013-10-29 17:57:20 UTC) #10
dglazkov
lgtm.
7 years, 1 month ago (2013-10-29 18:05:06 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/l.gombos@samsung.com/47623002/370001
7 years, 1 month ago (2013-10-29 18:14:13 UTC) #12
commit-bot: I haz the power
7 years, 1 month ago (2013-10-29 20:18:24 UTC) #13
Message was sent while issue was closed. 
Change committed as 160859

Powered by Google App Engine
This is Rietveld 408576698