Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1364)

Side by Side Diff: Source/core/rendering/RenderObject.cpp

Issue 47623002: Fix more warnings on linux (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Fix sign-compare and do not yet turn on -Wall. Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2000 Dirk Mueller (mueller@kde.org) 4 * (C) 2000 Dirk Mueller (mueller@kde.org)
5 * (C) 2004 Allan Sandfeld Jensen (kde@carewolf.com) 5 * (C) 2004 Allan Sandfeld Jensen (kde@carewolf.com)
6 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2011 Apple Inc. All rights reserv ed. 6 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2011 Apple Inc. All rights reserv ed.
7 * Copyright (C) 2009 Google Inc. All rights reserved. 7 * Copyright (C) 2009 Google Inc. All rights reserved.
8 * Copyright (C) 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/) 8 * Copyright (C) 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/)
9 * 9 *
10 * This library is free software; you can redistribute it and/or 10 * This library is free software; you can redistribute it and/or
(...skipping 1361 matching lines...) Expand 10 before | Expand all | Expand 10 after
1372 } 1372 }
1373 } 1373 }
1374 1374
1375 // If we have a flow thread, then we need to do individual repaints within t he RenderRegions instead. 1375 // If we have a flow thread, then we need to do individual repaints within t he RenderRegions instead.
1376 // Return the flow thread as a repaint container in order to create a chokep oint that allows us to change 1376 // Return the flow thread as a repaint container in order to create a chokep oint that allows us to change
1377 // repainting to do individual region repaints. 1377 // repainting to do individual region repaints.
1378 RenderFlowThread* parentRenderFlowThread = flowThreadContainingBlock(); 1378 RenderFlowThread* parentRenderFlowThread = flowThreadContainingBlock();
1379 if (parentRenderFlowThread) { 1379 if (parentRenderFlowThread) {
1380 // The ancestor document will do the reparenting when the repaint propag ates further up. 1380 // The ancestor document will do the reparenting when the repaint propag ates further up.
1381 // We're just a seamless child document, and we don't need to do the hac king. 1381 // We're just a seamless child document, and we don't need to do the hac king.
1382 if (&parentRenderFlowThread && parentRenderFlowThread->document() != doc ument()) 1382 if (parentRenderFlowThread->document() != document())
Nico 2013/10/29 15:51:30 yikes :-/ Apparently added in https://codereview.
1383 return repaintContainer; 1383 return repaintContainer;
1384 // If we have already found a repaint container then we will repaint int o that container only if it is part of the same 1384 // If we have already found a repaint container then we will repaint int o that container only if it is part of the same
1385 // flow thread. Otherwise we will need to catch the repaint call and sen d it to the flow thread. 1385 // flow thread. Otherwise we will need to catch the repaint call and sen d it to the flow thread.
1386 RenderFlowThread* repaintContainerFlowThread = repaintContainer ? repain tContainer->flowThreadContainingBlock() : 0; 1386 RenderFlowThread* repaintContainerFlowThread = repaintContainer ? repain tContainer->flowThreadContainingBlock() : 0;
1387 if (!repaintContainerFlowThread || repaintContainerFlowThread != parentR enderFlowThread) 1387 if (!repaintContainerFlowThread || repaintContainerFlowThread != parentR enderFlowThread)
1388 repaintContainer = parentRenderFlowThread; 1388 repaintContainer = parentRenderFlowThread;
1389 } 1389 }
1390 return repaintContainer; 1390 return repaintContainer;
1391 } 1391 }
1392 1392
(...skipping 2000 matching lines...) Expand 10 before | Expand all | Expand 10 after
3393 { 3393 {
3394 if (object1) { 3394 if (object1) {
3395 const WebCore::RenderObject* root = object1; 3395 const WebCore::RenderObject* root = object1;
3396 while (root->parent()) 3396 while (root->parent())
3397 root = root->parent(); 3397 root = root->parent();
3398 root->showRenderTreeAndMark(object1, "*", object2, "-", 0); 3398 root->showRenderTreeAndMark(object1, "*", object2, "-", 0);
3399 } 3399 }
3400 } 3400 }
3401 3401
3402 #endif 3402 #endif
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698